stack/2 turbomodule core by al-af · Pull Request #693 · AppsFlyerSDK/appsflyer-react-native-plugin

al-af · 2026-08-04T10:29:10Z

_{Stack created with GitHub Stacks CLI • Give Feedback 💬}

Unrelated tooling addition, not part of the RPC rewrite.

Adds MIGRATION.md and documents the new executeRpc bridge contract.

Removes vendored per-feature ObjC headers/RNAppsFlyer.m in favor of RNAppsFlyer.mm dispatching to RNAppsFlyerImpl.swift.

Converts RNAppsFlyerModule/Package to Kotlin, adds RpcInitGate to buffer listener registration until init resolves, and vendors the plugin_bridge + af-android-sdk aars.

index.js now routes every native call through callRpc/callRpcVoid/callRpcWithCallback -> NativeAppsFlyer.executeRpc.

…nd Kotlin, drop legacy Buck/bundle scaffolding Removes vendored main.jsbundle and BUCK build files that predate autolinking; migrates AppDelegate/MainActivity/MainApplication to Swift/Kotlin to match the New Architecture bridge.

…llback Addresses PR #693 review comments (pazlavi). - Delete RpcInitGate.kt + RpcInitGateTest.kt; RNAppsFlyerModule.kt's executeRpc dispatches every RPC immediately, no gate/queue - Remove RNAppsFlyerImpl.swift's initCompleted/pendingRegistrations buffer; executeRpc dispatches immediately - Remove Android's scheduleSessionReadyFallback (synthesized onSessionReady after a timeout) -- per review, a callback that never fires is a native bug to investigate, not something to paper over; this fallback had already caused a double-fire race - android/build.gradle: failOnNoDiscoveredTests = false (module has zero unit tests left now that it's a pure passthrough) - Update bridge-patterns.md §4, native-android.md, native-ios.md §4, testing.md, CLAUDE.md to document the removal and stop contradicting it Verified: ./gradlew :react-native-appsflyer:test green, npm test JS suite green (92/92 in index.test.js)

Adds an invalidate() override that shuts down rpcExecutor so it doesn't leak past TurboModule teardown (bridge/context invalidation, multi-instance RN hosts). Originally bundled with a session-ready exactly-once delivery guard (AtomicBoolean + sessionReadyScheduler shutdown) that is now moot -- the session-ready fallback timer this guarded against was removed in the prior commit, per PR #693 review.

…p deeplinkPath Addresses PR #695 review comments (pazlavi): - ConversionData collapsed to `{ [key: string]: any }` -- native hands back an untyped Map<String, Object>, not a fixed shape, so stop pretending otherwise. - UnifiedDeepLinkData renamed to DeepLinkResult, matching the native type name. Shape unchanged (already verified against native source). - GenerateInviteLinkParams.deeplinkPath removed outright, along with its dead console.warn branch in generateInviteLink -- it never shipped, so there's no deprecation window to honor. - onInstallConversionData/onInstallConversionFailure/onDeepLink renamed to onConversionDataSuccess/onConversionDataFail/onDeepLinking, matching the native SDK's own event names exactly. Since 7.0.0/7.0.1 have no git tag yet, this lands as one rename within the same unreleased major, not a second breaking change stacked on top of it. Propagated the rename across index.ts (impl, AppsFlyerApi interface, RPC event demux, listener buckets), all four Jest test files, example/src/App.tsx, both demo apps, and living docs (MIGRATION.md, CHANGELOG.md, Docs/RN_API.md and friends, .claude/rules/*, CLAUDE.md). Also updated .af-e2e/test-plan.json and .af-smoke/rc-test-plan.json's log-pattern matchers, which depend on the exact callback name logged by example/src/App.tsx and would have silently stopped matching otherwise. Also fixed two stale "native buffers registrations until init completes" comments (MIGRATION.md, Docs/RN_API.md, example/src/App.tsx) left over from PR #693's RpcInitGate removal -- that buffer no longer exists, so the claim was already false before this change. Left known-issues-kb.md, specs/, Docs/plans/, schemas/ untouched -- historical incident log and gitignored point-in-time planning artifacts, not living docs. Verified: npx tsc --noEmit clean, npm test 311/311, npm run lint clean.

Updates the `blockDir` regex in `metro.config.js` to prevent ReDoS vulnerabilities through improved escaping. Forces an upgrade of `brace-expansion` via `overrides` to mitigate known transitive dependency vulnerabilities.

Removes the `react-doctor` dependency as it is no longer required for TurboModule core development.

Adds an invalidate() override that shuts down rpcExecutor so it doesn't leak past TurboModule teardown (bridge/context invalidation, multi-instance RN hosts). Originally bundled with a session-ready exactly-once delivery guard (AtomicBoolean + sessionReadyScheduler shutdown) that is now moot -- the session-ready fallback timer this guarded against was removed in the prior commit, per PR #693 review.

…p deeplinkPath Addresses PR #695 review comments (pazlavi): - ConversionData collapsed to `{ [key: string]: any }` -- native hands back an untyped Map<String, Object>, not a fixed shape, so stop pretending otherwise. - UnifiedDeepLinkData renamed to DeepLinkResult, matching the native type name. Shape unchanged (already verified against native source). - GenerateInviteLinkParams.deeplinkPath removed outright, along with its dead console.warn branch in generateInviteLink -- it never shipped, so there's no deprecation window to honor. - onInstallConversionData/onInstallConversionFailure/onDeepLink renamed to onConversionDataSuccess/onConversionDataFail/onDeepLinking, matching the native SDK's own event names exactly. Since 7.0.0/7.0.1 have no git tag yet, this lands as one rename within the same unreleased major, not a second breaking change stacked on top of it. Propagated the rename across index.ts (impl, AppsFlyerApi interface, RPC event demux, listener buckets), all four Jest test files, example/src/App.tsx, both demo apps, and living docs (MIGRATION.md, CHANGELOG.md, Docs/RN_API.md and friends, .claude/rules/*, CLAUDE.md). Also updated .af-e2e/test-plan.json and .af-smoke/rc-test-plan.json's log-pattern matchers, which depend on the exact callback name logged by example/src/App.tsx and would have silently stopped matching otherwise. Also fixed two stale "native buffers registrations until init completes" comments (MIGRATION.md, Docs/RN_API.md, example/src/App.tsx) left over from PR #693's RpcInitGate removal -- that buffer no longer exists, so the claim was already false before this change. Left known-issues-kb.md, specs/, Docs/plans/, schemas/ untouched -- historical incident log and gitignored point-in-time planning artifacts, not living docs. Verified: npx tsc --noEmit clean, npm test 311/311, npm run lint clean.

Updates the `blockDir` regex in `metro.config.js` files to prevent ReDoS vulnerabilities through improved escaping and anchoring. Forces an upgrade of `fast-uri` via `overrides` to mitigate known transitive dependency vulnerabilities.

Relocates the `fast-uri` override from the root `package.json` to the `demos/appsflyer-expo-app/package.json`. This ensures the override is applied only where specifically needed by the demo app, preventing potential unintended side effects on other packages in the monorepo.

Adds an invalidate() override that shuts down rpcExecutor so it doesn't leak past TurboModule teardown (bridge/context invalidation, multi-instance RN hosts). Originally bundled with a session-ready exactly-once delivery guard (AtomicBoolean + sessionReadyScheduler shutdown) that is now moot -- the session-ready fallback timer this guarded against was removed in the prior commit, per PR #693 review.

…p deeplinkPath Addresses PR #695 review comments (pazlavi): - ConversionData collapsed to `{ [key: string]: any }` -- native hands back an untyped Map<String, Object>, not a fixed shape, so stop pretending otherwise. - UnifiedDeepLinkData renamed to DeepLinkResult, matching the native type name. Shape unchanged (already verified against native source). - GenerateInviteLinkParams.deeplinkPath removed outright, along with its dead console.warn branch in generateInviteLink -- it never shipped, so there's no deprecation window to honor. - onInstallConversionData/onInstallConversionFailure/onDeepLink renamed to onConversionDataSuccess/onConversionDataFail/onDeepLinking, matching the native SDK's own event names exactly. Since 7.0.0/7.0.1 have no git tag yet, this lands as one rename within the same unreleased major, not a second breaking change stacked on top of it. Propagated the rename across index.ts (impl, AppsFlyerApi interface, RPC event demux, listener buckets), all four Jest test files, example/src/App.tsx, both demo apps, and living docs (MIGRATION.md, CHANGELOG.md, Docs/RN_API.md and friends, .claude/rules/*, CLAUDE.md). Also updated .af-e2e/test-plan.json and .af-smoke/rc-test-plan.json's log-pattern matchers, which depend on the exact callback name logged by example/src/App.tsx and would have silently stopped matching otherwise. Also fixed two stale "native buffers registrations until init completes" comments (MIGRATION.md, Docs/RN_API.md, example/src/App.tsx) left over from PR #693's RpcInitGate removal -- that buffer no longer exists, so the claim was already false before this change. Left known-issues-kb.md, specs/, Docs/plans/, schemas/ untouched -- historical incident log and gitignored point-in-time planning artifacts, not living docs. Verified: npx tsc --noEmit clean, npm test 311/311, npm run lint clean.

al-af added 10 commits July 23, 2026 17:34

chore: add speckit skill scaffolding

af32599

Unrelated tooling addition, not part of the RPC rewrite.

chore: update gitignore, test plan, and scenario runner script

92e96ae

docs: update rules, CLAUDE.md, and changelog for TurboModule RPC rewrite

f7d6444

Adds MIGRATION.md and documents the new executeRpc bridge contract.

feat(ios): replace per-method bridge with executeRpc TurboModule

a99b122

Removes vendored per-feature ObjC headers/RNAppsFlyer.m in favor of RNAppsFlyer.mm dispatching to RNAppsFlyerImpl.swift.

feat(android): replace per-method bridge with executeRpc TurboModule

b0e5871

Converts RNAppsFlyerModule/Package to Kotlin, adds RpcInitGate to buffer listener registration until init resolves, and vendors the plugin_bridge + af-android-sdk aars.

feat: add executeRpc TurboModule spec and typed JS API surface

0cf18da

index.js now routes every native call through callRpc/callRpcVoid/callRpcWithCallback -> NativeAppsFlyer.executeRpc.

test: cover executeRpc contract, threading, and updated JS API

8ab4406

feat(demo): migrate example app to executeRpc TurboModule bridge

e37eacc

feat(demo): update expo app and config plugin for TurboModule bridge

0870c57

al-af mentioned this pull request Aug 4, 2026

development #692

Closed