stack/6 final polish - #697
Merged
Merged
Conversation
al-af
force-pushed
the
stack/5-api-alignment
branch
from
August 5, 2026 07:06
52abf78 to
1434aa0
Compare
al-af
force-pushed
the
stack/6-final-polish
branch
from
August 5, 2026 07:09
b656f70 to
1f53ea8
Compare
al-af
force-pushed
the
stack/5-api-alignment
branch
from
August 5, 2026 07:40
1434aa0 to
242c625
Compare
al-af
force-pushed
the
stack/6-final-polish
branch
from
August 5, 2026 07:41
1f53ea8 to
4110e7f
Compare
pazlavi
previously approved these changes
Aug 5, 2026
al-af
force-pushed
the
stack/5-api-alignment
branch
from
August 5, 2026 08:38
242c625 to
78a8b9c
Compare
al-af
force-pushed
the
stack/6-final-polish
branch
2 times, most recently
from
August 5, 2026 09:16
786d3bc to
e22725f
Compare
al-af
force-pushed
the
stack/5-api-alignment
branch
from
August 6, 2026 07:55
a286002 to
879ad7e
Compare
al-af
force-pushed
the
stack/6-final-polish
branch
from
August 6, 2026 07:56
2efa7f2 to
3c22a05
Compare
al-af
force-pushed
the
stack/5-api-alignment
branch
from
August 6, 2026 08:43
879ad7e to
d7c38d9
Compare
…in AppDelegate The config plugin never injected AppsFlyerLib.shared().handleLaunchOptions(launchOptions) into didFinishLaunchingWithOptions on either ObjC or Swift, and the Swift continueUserActivity injection hardcoded restorationHandler to nil instead of forwarding the real closure. Both now match the manually-integrated reference pattern in demos/appsflyer-react-native-app's AppDelegate.swift. Docs updated to match.
plugin_bridge reports SHOUTING_CASE deep-link status/error names (FOUND/NOT_FOUND/ERROR) while iOS reports lowerCamelCase (found/notFound/failure). UnifiedDeepLinkData is typed against iOS's vocabulary, so Android-only apps comparing res.status/res.error would silently fail. normalizeDeepLinkEvent() maps Android's raw event to the shared vocabulary before it reaches JS. Also extracts a shared parseJsonOrDefault helper and adds the org.json test dependency needed to unit test JSON logic under Robolectric-less unit tests.
…ements warning AFLogEvent used the old 4-arg callback signature, which does not exist on the current TurboModule API (logEvent only returns a Promise) - the callbacks silently never fired. Switched to .then(). Also suppressed a confirmed-unfixable react-native-elements@3.4.3 PadView warning (un-keyed internal divider View) that fires whenever ListItem gets multiple children, as CartRow does.
MIGRATION.md's three overlapping lists (callback-removal prose, symbol table, alignment table) are replaced by one alphabetical Full API change reference table covering every affected symbol, plus a TOC and a tightened LLM-assistant prompt. Docs/RN_API.md gets an upgrading-from-6.x callout linking to MIGRATION.md, and its links into MIGRATION.md are repointed from anchors that never existed (table rows have no anchor) to real headings. The remaining Docs/*.md files get formatting cleanup and removal of stale 6.x-era examples, continuing the RPC-to-Plugin-API alignment doc pass from the previous commit.
- Introduces `setDisableAppleAdsAttribution` to allow disabling Apple Ads attribution on iOS. - Addresses a potential crash on iOS by ensuring `isUserSubjectToGDPR` defaults to `false` when omitted in `setConsentData` calls, aligning behavior with Android's native implementation. - Adds `verify-plugin-schema.js`, a new development script to validate `index.ts` RPC calls against the canonical AppsFlyer plugin schema, improving consistency checks.
…pr-review-comments.md
Migrates `index.js` and `index.d.ts` to a single typed `index.ts` entry point, enhancing type safety and maintainability. Updates documentation and demo app examples to provide clearer guidance on asynchronous API calls, native dispatch order, and proper `async`/`await` usage, especially for deep linking. Documents newly identified critical, unfixable native SDK issues for iOS (`devKey`/`appleAppID` TOCTOU race) and Android (`init()` timing with `reactApplicationContext`).
Pass `nil` to AppsFlyer's `continueUserActivity` restoration handler to avoid a Swift type mismatch. The AppsFlyer SDK only requires the `userActivity` object to extract OneLink URLs, and the full `restorationHandler` is processed by `RCTLinkingManager`.
al-af
force-pushed
the
stack/6-final-polish
branch
from
August 6, 2026 08:44
3c22a05 to
9f77e81
Compare
pazlavi
approved these changes
Aug 6, 2026
pazlavi
approved these changes
Aug 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack created with GitHub Stacks CLI • Give Feedback 💬