Add Tasks skill for CLI bootstrap and browser plan review - #5
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Review on ArchCode
Problem and author intent
Coding agents can install the public Rooms skill, but have no equivalent Tasks skill explaining how to bootstrap ArchDev and drive a human plan review. The CLI already owns draft validation, revision-aware feedback, approval, and durable task IDs; agents need an executable workflow around those commands.
This adds an independently installable Tasks skill that converts a conversation or harness plan into a dependency graph, opens browser review, revises the same plan from feedback, and verifies that approval saved Tasks.
What changed
Scope: CLI distribution and agent instructions; no backend or frontend runtime changes. Users can install the skill and ask their coding agent to manage the review loop. The human retains approval of saving Tasks; implementation remains a separate request.
Risk
Low: runtime changes are confined to bootstrap scripts following the existing Rooms pattern. Instructions can still steer incorrect agent behavior, so the example and workflow were checked against the CLI source and independently reviewed.
Testing
bash tests/tasks-skill.sh. Canonical packaging/bootstrap proof: tests/tasks-skill.sh, the complete script target. It crosses the real skills-manager process boundary for global and repository installs, then invokes the installed bootstrap against a fixture installer/CLI. It asserts an absolute executable path, reuse without installation, upgrade of an outdated CLI, and failure without a misleading successful path. The release/account boundary is substituted; this is not a live Tasks end-to-end proof..github/workflows/installer-smoke-test.yml→tasks-skill→bash tests/tasks-skill.sh, on every pull request, main push, and manual dispatch. No Aster target exists in this public distribution repository; the workflow runs the script directly without test filters or skips.git diff --check.parseTaskReviewDraftimplementation; checked installed CLI 0.35.4 command help and bootstrap reuse.Follow-ups and limitations
The live browser → local review server → authenticated Tasks API journey was not run for this documentation/distribution change. A dedicated test account and browser-connected environment are needed to exercise and automatically cover that boundary. The new CI job verifies installation/bootstrap only. PowerShell bootstrap was reviewed against the Rooms exemplar but not executed locally; it has no dedicated Tasks bootstrap CI coverage yet.