fix(rooms): make independent installation and Knowledge recall usable - #9
Merged
Merged
Conversation
Contributor
Author
|
The first native Windows run passed the new Rooms bootstrap scenarios but failed when the actual installer could not connect to its fixture server. b04ea01 keeps server startup, bounded HTTP readiness, installation/version verification, and cleanup in one step, with server logs on failure. Local PowerShell parsing and real HTTP readiness/cleanup checks passed; Windows CI remains the gate. Independent spec review and Claude focused re-review approved this workflow-only fix (session c006907f-2a5b-4197-a967-745c823c2e86). No product or installer-pin changes. |
vks-archastro
enabled auto-merge (rebase)
September 9, 2026 23:46
bruno-archastro
approved these changes
Sep 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Review on ArchCode
Problem and author intent
A clean Rooms install failed because the shared installer still required the retired dashboard binary. Existing users with a lifecycle-only CLI could also skip upgrading and miss Knowledge search. The skill did not explain approved decisions, incomplete recall or the actual Knowledge provenance shape.
This fixes those concrete gaps using the existing CLI, installer and skill-manager paths. No resident, daemon, migration tooling, PR-evidence package or new backend.
What changed
9d50e7ce1e64a731d88cca8ae15ec2c45b1375df, upgrades a CLI lacking Knowledge search, and rejects an incompatible replacement.rooms connect.Scope, risk and user impact
Distribution/CLI skill only; low-to-medium risk because installer behavior affects fresh installations across domains. The change removes a demonstrably obsolete sidecar requirement without touching auth, Room membership, the server Knowledge system or existing ArchAgents behavior.
Rooms remains independently installable; ArchDev is its sole runtime. Other domains can be adopted separately.
Testing
Canonical packaging/bootstrap proof: tests/rooms-skill.sh. The actual skill manager installs both scopes into isolated homes/repos. The installed bootstrap invokes separate installer/CLI fixture processes; assertions cover exact returned executable, absent CLI, lifecycle-only upgrade, capable CLI reuse and incompatible-install rejection. This proves installation boundaries, not live authentication or Knowledge retrieval.
Canonical Windows proof: tests/rooms-bootstrap.ps1, invoked by the Windows Installer job. It runs production bootstrap and native executable fixtures across upgrade/reuse/reject cases; the download is substituted. Native Windows execution remains a merge gate.
dbedaeed-a5d8-4e08-b3e0-50efcb455195). Its command-availability caveat was checked against actual v0.35.5.git diff --checkpass.Follow-ups and known limits
Full fresh browser-sign-in → live agent → teammate Knowledge reuse remains unverified without a local Platform stack; fixture tests are not claimed as that proof. Existing CLI process and backend ingestion/access tests passed separately.
Firstlanding PR #13097 fixes the existing records reader truncating approved decisions after 100 records. The public skill works with current Knowledge-capable releases; that completeness fix becomes available in a subsequent CLI release.
Other domain skills retain their existing installer pins; this PR updates Rooms only. Automatic PR evidence and migration tooling remain intentionally excluded.