Repository navigation
fix(streaming,realtime): cancel a pending connect() when close() is called - #192
Open
RaphaelFakhri wants to merge 1 commit into
Open
RaphaelFakhri wants to merge 1 commit into
RaphaelFakhri wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cancel a pending
connect()whenclose()is called, for bothStreamingTranscriberandRealtimeTranscriber.Problem
StreamingTranscriber.close()removes the socket but does not stop the retry loop inconnect(). After the attempt times out, the loop opens a new socket, so a connection is created afterclose()returned. It can also resolveconnect()on a transcriber the caller already closed.RealtimeTranscriber.close()removes the socket listeners, so a pendingconnect()promise never settles.Changes
StreamingTranscriber:close()increments a connect epoch and cancels the attempt in flight.connect()checks the epoch before each attempt and after each retry delay, and rejects withConnection closed before the session started. Callingconnect()again afterclose()still works.RealtimeTranscriber:close()rejects the pendingconnect()promise with the same message.Tests
New tests in
tests/unit/streaming-close-during-connect.test.tsandtests/unit/realtime-close-during-connect.test.ts:close()while an attempt is pending.close()runs during the retry delay.connect()can be called again afterclose().RealtimeTranscriber.connect()rejects whenclose()is called beforeSessionBegins.Before the change, all four fail. After the change, all four pass.
pnpm lint:eslint,pnpm lint:tscandpnpm lint:formatpass.