Repository navigation
fix(live): cancel a web ReadableStream source when the upload stops early - #194
Open
RaphaelFakhri wants to merge 1 commit into
Open
RaphaelFakhri wants to merge 1 commit into
RaphaelFakhri wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
liveChunks()reads a webReadableStreamthrough a reader and only releases the lock when the generator ends. If the upload stops before the stream is exhausted, the source is never cancelled and keeps producing data nobody reads.The upload stops early when:
finish()ends the body,asBytes()throws.Node streams and other async iterables do not have this problem, because
for awaitcloses them when the loop exits early. This change cancels the reader when the generator exits without having read the stream to its end, so a web stream source behaves the same way.The fix applies to
sync.transcribeLive()anddictation.transcribeLive(), which both pass their input throughliveChunks().Changes
liveChunks().finallyblock when it was not, and ignore a cancel failure from a stream that already errored.Testing
Run
pnpm test:unit. The new tests are intests/unit/live-chunks.test.ts. Without the change insrc/utils/live.ts, the early-stop and non-bytes tests fail because the source'scancelcallback is never called.Fixes #193