Skip to content

refactor: share the app icon and wordmark from Design/brand - #228

Merged
he-james merged 4 commits into
mainfrom
ios/shared-brand-assets
Oct 14, 2026
Merged

he-james merged 4 commits into
mainfrom
ios/shared-brand-assets

Conversation

@he-james

@he-james he-james commented Oct 2, 2026

Copy link
Copy Markdown
Contributor

What & why

The iPhone project pulled the app icon and wordmark straight out of the Mac app's folder (../Blurt/Blurt/...), so a Mac-side rename would break the iPhone build. Both now live in a top-level Design/brand/ that each project references directly, so neither app depends on the other's folder.

  • AppIcon.icon and blurt-ready-logo.png move to Design/brand/ (plus a short Design/README.md).
  • The Mac project lists them explicitly instead of getting them via its Blurt/ folder; project.pbxproj regenerated.

Stacked on #227.

How it was tested

  • Mac app builds (Debug, unsigned, as check.sh does); the bundle has AppIcon.icns, Assets.car and blurt-ready-logo.png.

  • scripts/ios-check.sh passes (134/134); the iPhone bundle has its icon and logo, and the wordmark renders in the simulator.

  • prettier, markdownlint, swiftlint clean on touched files.

  • I read AGENTS.md and this doesn't reintroduce anything deliberately removed

  • Docs updated (Design/README.md)

🤖 Generated with Claude Code

he-james and others added 3 commits October 2, 2026 16:55
Gets the iPhone app ready for TestFlight.

- Bundle ids move from the dev.alex placeholders to
  com.assemblyai.blurt.ios (app, .keyboard, .core, .tests, .probe), the
  App Group to group.com.assemblyai.blurt.ios, and the term-pack type to
  com.assemblyai.blurt.terms. The Darwin notification names, log
  subsystem, queue labels and scripts follow. The Mac app keeps its
  dev.alex ids: changing them would orphan Sparkle updates and its
  granted Accessibility permission.
- API-key entry is no longer debug-only. Sign in with AssemblyAI
  doesn't exist yet, so a TestFlight build had no way to add a key. The
  setup card and Settings now offer "Paste your key" and "Get a free
  key" in every build, as the Mac app does.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
App Review 5.1.2(i) requires clearly disclosing where personal data
goes, third-party AI included, and getting explicit permission first.

The listening window now won't open until the user agrees, in a sheet
that names AssemblyAI, lists what is sent (the voice while dictating,
the text before the cursor, recent dictations, key terms with contact
names) and links the privacy policy. Every path to the microphone goes
through startListening(), so one gate covers the button, the keyboard's
blurt://start and in-app dictation. Consent is versioned (AIConsent):
sending something new means a new version, and everyone is asked again.

Settings' About section links the privacy policy too. The debug
-BlurtStartListening flag grants consent, since scripted runs can't tap
through the sheet.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The iPhone project pulled the app icon and the wordmark straight out of
the Mac app's folder, so a Mac-side move or rename would have broken
the iPhone build. Both now live in a top-level Design/brand that each
project references directly; neither app's folder is a dependency of
the other.

The Mac project lists them explicitly (it used to get them by including
its whole Blurt folder) and its project.pbxproj is regenerated. Both
app bundles still carry the icon and logo.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@he-james
he-james requested review from alexkroman and nbisht-aai and removed request for alexkroman October 2, 2026 22:39
@he-james
he-james marked this pull request as ready for review October 2, 2026 22:40
Base automatically changed from ios/ai-consent to ios/org-owned-identifiers October 14, 2026 20:17
Base automatically changed from ios/org-owned-identifiers to main October 14, 2026 20:37
@he-james
he-james enabled auto-merge (squash) October 14, 2026 21:15
Resolves App/BlurtiOS/project.yml: keeps the Design/brand asset paths from
this branch and main's per-target TARGETED_DEVICE_FAMILY "1", camera
purpose string and build 2 (#245).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@he-james
he-james merged commit 2657fef into main Oct 14, 2026
12 checks passed
@he-james
he-james deleted the ios/shared-brand-assets branch October 14, 2026 21:52
he-james added a commit that referenced this pull request Oct 14, 2026
Resolves App/BlurtiOS/project.yml: keeps this branch's AssemblyAI product
link and main's per-target TARGETED_DEVICE_FAMILY "1", camera purpose
string, build 2 (#245) and Design/brand paths (#228).

main's new read-aloud code (#225) uses HTTPTransport, which this branch
moves into the AssemblyAI module, so ReadAloudLLM.swift and the tests that
reach it (ReadAloudLLMTests, AssemblyAISpeechSynthesizerTests,
AssemblyAITranscriberTests, AsyncStreamFixtures) now import AssemblyAI.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants