Repository navigation
Conversation
|
|
||
|
|
||
| def test_manifest_shaped_secret_round_trips(): | ||
| secret = "assemblyai-chunks-v1:" + "a" * 32 + ":1" |
There was a problem hiding this comment.
Exposed secret in tests/test_keyring_large.py - low severity
Detected a Generic API Key, potentially exposing access to various services and sensitive operations.
Reply @AikidoSec ignore: [REASON] to ignore this issue.
More Info
Author
There was a problem hiding this comment.
This is a synthetic test fixture, not a credential. The value is constructed locally as "assemblyai-chunks-v1:" + "a" * 32 + ":1"; it is not issued by any service and grants no access. The test intentionally uses a string matching the versioned chunk-manifest format to verify that a secret with that shape can still be stored and read back unchanged. Changing it to a non-matching placeholder would remove that regression coverage.
kosesena
marked this pull request as ready for review
September 13, 2026 16:25
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Browser login stores the session JWT and token together, which can exceed the Windows Credential Manager's 2560-byte limit and trigger the CredWrite failure reported in #276.
This keeps short entries compatible and stores larger secrets as bounded ASCII chunks in the OS keyring. It publishes a versioned manifest after all chunks are written, retains the old value on a failed write, removes replaced/deleted chunks, and supports rollback and corrupt-entry reads. No plaintext file fallback or additional dependency is introduced.
Validation: regression test fails on the original implementation under a simulated Windows byte limit; 60 targeted tests pass with 100% statement and branch coverage of keyring_store. Full offline suite: 3732 passed, with the same two terminal-rendering failures reproduced on unmodified main (3723 passed there). Actual Windows validation and the complete repository gate remain pending. The local gate passed lint, formatting, type, architecture and complexity checks, then stopped because markdownlint is unavailable.
Draft for maintainer review of the storage approach; not claiming Windows CI or all required gates are green.