strip userinfo from the absolute-form proxy request target#2258
Open
madib06ops wants to merge 1 commit into
Open
strip userinfo from the absolute-form proxy request target#2258madib06ops wants to merge 1 commit into
madib06ops wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a plaintext request goes through an HTTP proxy, requestUri() builds the absolute-form request target with Uri.toUrl(), which embeds the userinfo, so a request for http://user:secret@origin.example.com/resource sends those credentials to the proxy in the clear on the request line and into its access log. RFC 9110 section 4.2.4 says a sender must not generate the userinfo subcomponent when a request target is built. The sibling paths already comply: CONNECT uses getAuthority(), the Host header comes from hostHeader(uri), and the HTTP/2 path runs stripUserInfo() before setting :authority, so only the HTTP/1.1 absolute-form branch was missed. Kept toUrl() and the caller-visible Request.getUrl() unchanged and added a variant that omits the userinfo, with a test that fails on the current request line.