fix(touchcontrols): rendering joysticks and moving ui logic SYNTH-183#1359
Open
Dhruv-0-Arora wants to merge 10 commits into
Open
fix(touchcontrols): rendering joysticks and moving ui logic SYNTH-183#1359Dhruv-0-Arora wants to merge 10 commits into
SYNTH-183#1359Dhruv-0-Arora wants to merge 10 commits into
Conversation
…nent dependency Signed-off-by: Dhruv Arora <dhruv.arora1@autodesk.com>
Dhruv-0-Arora
added
the
ui/ux
Dhruv-0-Arora
changed the title
SYNTH-183
Signed-off-by: Dhruv Arora <dhruv.arora1@autodesk.com>
Dhruv-0-Arora
force-pushed
the
darora1/183/fix-joysticks-mobile
branch
from
68bde1e to
ca411b9
Compare
Dhruv-0-Arora
commented
Jul 2, 2026
rutmanz
requested changes
Jul 2, 2026
rutmanz
left a comment
rutmanz
left a comment
Member
There was a problem hiding this comment.
Looks like they render on top of panels, which probably isn't desirable
I also think that this button needs a verb attached if it isn't going to open a panel.
…UD button Signed-off-by: Dhruv Arora <dhruv.arora1@autodesk.com>
rutmanz
requested changes
Jul 2, 2026
Signed-off-by: Dhruv Arora <dhruv.arora1@autodesk.com>
rutmanz
approved these changes
Jul 7, 2026
Co-authored-by: Zach Rutman <zarutman+git@gmail.com>
…cks-mobile # Conflicts: # fission/src/ui/components/TouchControls.tsx
PepperLola
requested changes
Jul 10, 2026
PepperLola
left a comment
PepperLola
left a comment
Member
There was a problem hiding this comment.
Looks good overall; I just had one suggestion and one issue. When holding down a joystick, the toggle joysticks button doesn't do anything (which is good), but it seems like it still toggles whether Fission thinks the joysticks are visible. This means that if you've pressed the toggle button an odd number of times while holding a joystick, releasing the joystick and pressing it again does nothing, but a subsequent toggle would hide them.
To test:
- Hold joystick down to rotate robot, click toggle (nothing should happen).
- Release joystick and press toggle button (nothing should happen again).
- With joystick still released, press toggle (joysticks should disappear).
Co-authored-by: Julian Wright <PepperLola@users.noreply.github.com>
toggling while a joystick is held still flipped Fission's internal visibility state, desyncing it from what's shown Signed-off-by: Dhruv Arora <dhruv.arora1@autodesk.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task
Touch Controls currently do not appear when you click the button on the MainHUD because they were removed from the Synthesis.tsx for rendering likely due to a mistake during conflict resolution. This PR adds the touch controls back and also moves the joystick styling logic to react-joystick-component
SYNTH-183
Before merging, ensure the following criteria are met: