Skip to content

Update Vite (partial [SYNTH-145])#1388

Open
0xda157 wants to merge 1 commit into
devfrom
dionkud/vite-update
Open

Update Vite (partial [SYNTH-145])#1388
0xda157 wants to merge 1 commit into
devfrom
dionkud/vite-update

Conversation

@0xda157

@0xda157 0xda157 commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

Task

part of SYNTH-145

Symptom

Solution

Verification


Before merging, ensure the following criteria are met:

  • All acceptance criteria outlined in the ticket are met.
  • Necessary test cases have been added and updated.
  • A feature toggle or safe disable path has been added (if applicable).
  • User-facing polish:
    • Ask: "Is this ready-looking?"
  • Cross-linking between Jira and GitHub:
    • PR links to the relevant Jira issue.
    • Jira ticket has a comment referencing this PR.

@0xda157 0xda157 requested review from a team as code owners July 8, 2026 19:29
@0xda157 0xda157 marked this pull request as draft July 8, 2026 19:30
@0xda157 0xda157 force-pushed the dionkud/vite-update branch 6 times, most recently from 7dc3519 to f56a857 Compare July 8, 2026 20:26
@0xda157 0xda157 force-pushed the dionkud/vite-update branch from f56a857 to eb1ce02 Compare July 8, 2026 20:33
@0xda157 0xda157 requested a review from rutmanz July 8, 2026 20:33
@0xda157 0xda157 marked this pull request as ready for review July 8, 2026 20:33

@rutmanz rutmanz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tests are failing, but also is there a reason to go one dependency at a time rather than all at once? A lot of these things have peer dependencies on different versions so to me it makes sense to try and upgrade everything in one PR

@rutmanz rutmanz changed the title update vite Update Vite Part of [SYNTH-145] Jul 9, 2026
@rutmanz rutmanz changed the title Update Vite Part of [SYNTH-145] Update Vite (partial [SYNTH-145]) Jul 9, 2026
@0xda157

0xda157 commented Jul 9, 2026

Copy link
Copy Markdown
Contributor Author

is there a reason to go one dependency at a time rather than all at once?

I think that updating our testing code should be separate from updating our actual UI, so that there is less opportunity to miss regressions.

A lot of these things have peer dependencies on different versions so to me it makes sense to try and upgrade everything in one PR

Sure it makes sense if the dependencies are peers of each other, then we should update them together, but that isn't the case for vite. it only depends on the vite plugins

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants