Skip to content

flake: disable playwright setup#1400

Open
0xda157 wants to merge 1 commit into
devfrom
dionkud/flake-remove-playwright
Open

flake: disable playwright setup#1400
0xda157 wants to merge 1 commit into
devfrom
dionkud/flake-remove-playwright

Conversation

@0xda157

@0xda157 0xda157 commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

Currently the playwright used by the nix shell is somehow setup incorrectly (which I tried to fix, unsuccessfully, see SYNTH-209). Temporary disabling it lets bun/npm use the globally installed playwright, which allows me to run the tests.


Before merging, ensure the following criteria are met:

  • All acceptance criteria outlined in the ticket are met.
  • Necessary test cases have been added and updated.
  • A feature toggle or safe disable path has been added (if applicable).
  • User-facing polish:
    • Ask: "Is this ready-looking?"
  • Cross-linking between Jira and GitHub:
    • PR links to the relevant Jira issue.
    • Jira ticket has a comment referencing this PR.

@0xda157 0xda157 requested a review from azaleacolburn July 9, 2026 20:46
@0xda157 0xda157 requested review from a team as code owners July 9, 2026 20:46
@0xda157 0xda157 requested a review from PepperLola July 9, 2026 20:46
@0xda157 0xda157 force-pushed the dionkud/flake-remove-playwright branch from 478b9d2 to 3e1583c Compare July 10, 2026 21:20

@PepperLola PepperLola left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me if it works for you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants