Skip to content

Remove joint config options on Codesim#1403

Open
RoushilS wants to merge 1 commit into
devfrom
roushils/234/remove-joint-options-codesim
Open

Remove joint config options on Codesim#1403
RoushilS wants to merge 1 commit into
devfrom
roushils/234/remove-joint-options-codesim

Conversation

@RoushilS

Copy link
Copy Markdown
Contributor

Task

SYNTH-234

Symptom

When the user is doing code simulation and the brain is set to WPILib, the joint configurationand sequence options are visible in the configure assets panel. This can be confusing, and hinder the user as these options are not used during code simulation.

Solution

Add a check to see if the brain is synthesis before adding the config selection option, in the configure panel.

Verification

  • Joint selection options are hidden on wpilib brain, but are still functional.

Before merging, ensure the following criteria are met:

  • All acceptance criteria outlined in the ticket are met.
  • Necessary test cases have been added and updated.
  • A feature toggle or safe disable path has been added (if applicable).
  • User-facing polish:
    • Ask: "Is this ready-looking?"
  • Cross-linking between Jira and GitHub:
    • PR links to the relevant Jira issue.
    • Jira ticket has a comment referencing this PR.

@RoushilS RoushilS marked this pull request as ready for review July 10, 2026 22:28
@RoushilS RoushilS requested review from a team as code owners July 10, 2026 22:28
@RoushilS RoushilS self-assigned this Jul 10, 2026
Comment on lines +379 to +383
new ConfigModeSelectionOption(
"Configure Joints",
ConfigMode.SUBSYSTEMS,
"Set the velocities, torques, and accelerations of your robot's motors."
),

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we would still want to be able to configure joints in code sim mode so that they could match with the actual robot design, it's just sequencing that doesn't really make sense because the robot code would do that for you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants