[Design Exploration] Browser-style preview toolbar - #4746
Conversation
Resolve conflicts in the preview toolbar in favor of the branch's browser-style address bar, carrying trunk's @wordpress/ui 0.21.0 migration onto it: the renamed design tokens, the literal elevation shadow, and the label now required on KeyboardShortcut. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
|
@shaunandrews I merged trunk, resolved the conflict, tested, and fixed minor issues. I think it solves STU-2370. I see potential improvements:
|
Picking an element opens a note while picking stays on, so testing isPicking first made the note-dismiss branch unreachable and Escape jumped straight to the discard-everything prompt. Report state when a note is dropped so a later cancel isn't gated on a draft that no longer exists. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
|
Two more small things:
|
📊 Performance Test ResultsComparing 7349286 vs trunk app-size
site-editor
site-startup
Results are median values from multiple test runs. Legend: 🟢 Improvement (faster) | 🔴 Regression (slower) | ⚪ No change (<50ms diff) |
|
I've been testing it, and it's very clear and very easy to use. Great job, @shaunandrews. In addition to @wojtekn's comments above, I just have three small suggestions:
|
…app, including phpMyAdmin
…hen labels collapse
…iew-toolbar # Conflicts: # apps/ui/src/ui-classic/components/session-view/index.tsx
|
Thanks @shaunandrews , it's much smoother now. I think those still stand:
Thanks for adding phpMyAdmin to "Open in". What if we changed this one to open phpMyAdmin in an external browser, so it's consistent with other actions in this menu? If the user wants to use phpMyAdmin in the internal browser, they can still click in the address bar and pick the database there. |
|
My bad @wojtekn I definitely read your feedback, but just got lost in the shuffle!
I remove the navigation controls, because those break the annotation feature. But I like being able to switch views while annotating to give the agent notes about mobile or other viewport-specific options.
But you're right that the experience has some rough edges; I've tried to smooth over some of the more common ones:
It took me a while to see your point here, but now I agree. The "Open in..." browser option now opens your homepage in your browser. I've added a new control to the preview toolbar to let you quickly open the current page in your browser.
Done! |
…d phpMyAdmin in the OS browser
…cord the viewport per note
Makes sense, thanks for sharing more on this use case. I tested it now, and it works better.
Thanks for considering it - it is much more consistent now. The location you chose for the new control is even better than the one I proposed. |


















Related issues
How AI was used in this PR
AI assisted with iterative implementation, refactoring, and test updates. Shaun directed the interaction and visual design through hands-on review of the running Studio preview, including toolbar spacing, responsive behavior, control states, icon treatment, and dark-mode corrections.
Proposed Changes
This is intentionally a design exploration. The interaction model and visual treatment are presented for feedback rather than as a final approved direction.
Current screenshots
The set below covers the address menu and recents, compact toolbar behavior, dark mode, and the disabled Database state.
Testing Instructions
Automated verification completed for the latest update:
npm test -- apps/ui/src/components/site-preview/address-bar.test.tsx apps/ui/src/components/site-preview/index.test.tsx apps/ui/src/components/site-preview/inspector-script.test.ts(65 tests)npm run typecheck -w @studio/uinpm run cli:build:uion the combined exploration branchPre-merge Checklist