Repository navigation
Conversation
There was a problem hiding this comment.
Pull request overview
Improves robustness of the PHP feature installation script by preventing transient PECL channel update failures from aborting installs, and fixes case statement termination to avoid shell syntax issues.
Changes:
- Allow
pecl* channel-update pecl.php.netfailures to be non-fatal across Alpine and Debian/Ubuntu setup paths. - Allow the final
pecl update-channelsstep to fail without stopping the script. - Fix missing
;;/termination incaseblocks and adjust related shell formatting for correctness.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
sjinks
force-pushed
the
pltfrm-2570-codespaces-pecl-channel-update-is-build-critical-transient
branch
from
July 27, 2026 10:45
c11cf51 to
b64112c
Compare
sjinks
force-pushed
the
pltfrm-2570-codespaces-pecl-channel-update-is-build-critical-transient
branch
from
July 27, 2026 12:16
b64112c to
9236d3a
Compare
sjinks
deleted the
pltfrm-2570-codespaces-pecl-channel-update-is-build-critical-transient
branch
July 27, 2026 13:01
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request makes the PHP installation script more robust by ensuring that failures during PECL channel updates do not interrupt the installation process. This is achieved by allowing the
pecl channel-updateandpecl update-channelscommands to fail without causing the script to exit. Additionally, a minor fix was made to ensure proper case statement termination.Error handling improvements:
pecl channel-update pecl.php.netcommands in both Alpine and Debian/Ubuntu PHP setup functions now use|| trueto prevent script failure if the channel update fails. [1] [2] [3] [4] [5] [6] [7] [8]pecl update-channelscommand at the end of the script also uses|| truefor the same reason.Script correctness:
;;to properly terminate a case statement, preventing potential syntax errors.