Skip to content

fix(php): use Ondrej PPA with noble suite for Ubuntu Resolute - #549

Closed
sjinks with Copilot wants to merge 2 commits into
trunkfrom
copilot/fix-php-ci-failure-548
Closed

sjinks with Copilot wants to merge 2 commits into
trunkfrom
copilot/fix-php-ci-failure-548

Conversation

Copilot AI commented Jul 27, 2026 •

Copy link
Copy Markdown

PR #548 broke PHP installation on Ubuntu Resolute by routing it through packages.sury.org/php with suite name resolute. Sury only publishes Debian suite names; apt cannot resolve resolute there.

Changes

  • features/src/php/install.sh: Keep all Ubuntu releases on the Ondrej PHP PPA. For resolute, use noble as the PPA suite (last known-compatible); all other Ubuntu releases use their host codename. Uses a local PPA_SUITE variable — CODENAME is never mutated.
if [ "${CODENAME}" = "resolute" ]; then
    PPA_SUITE="noble"
else
    PPA_SUITE="${CODENAME}"
fi
echo "deb http://ppa.launchpad.net/ondrej/php/ubuntu ${PPA_SUITE} main" > /etc/apt/sources.list.d/php.list
  • features/src/php/devcontainer-feature.json: Bump version 2.10.1 → 2.10.2.
Original prompt

Fix the PHP feature CI failure introduced by #548 (merge commit d749f26). In features/src/php/install.sh, the Ubuntu Resolute branch currently uses packages.sury.org/php with the Ubuntu suite name resolute. Sury packages target Debian suites, so apt cannot resolve that suite on Ubuntu. Keep Ubuntu installations on the Ondrej PHP PPA; for the resolute codename, use the known-compatible noble PPA suite while preserving the host codename for all other Ubuntu releases. Avoid mutating the general CODENAME variable if a local PPA suite variable is clearer. Bump features/src/php/devcontainer-feature.json's version appropriately for this new feature release. Add or update the most focused existing automated coverage available for the source-suite selection (if tests exist), and run the relevant project checks. Keep the patch narrow and do not change unrelated formatting.

Copilot AI changed the title [WIP] Fix PHP feature CI failure introduced by #548 fix(php): use Ondrej PPA with noble suite for Ubuntu Resolute Jul 27, 2026
Copilot AI requested a review from sjinks July 27, 2026 10:31
@sjinks sjinks closed this Jul 27, 2026
@sjinks
sjinks deleted the copilot/fix-php-ci-failure-548 branch July 27, 2026 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants