Repository navigation
chore: remove outdated PHP 8.1 - #551
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR removes PHP 8.1 support from the devcontainer PHP and Xdebug features, their test scenarios, and CI workflows, updating the supported/minimum PHP versions to 8.2+.
Changes:
- Removed PHP 8.1 scenarios from feature test matrices and global scenarios.
- Removed PHP 8.1 install paths from the PHP and Xdebug feature install scripts and updated feature metadata/versions.
- Updated GitHub Actions workflows to stop running PHP 8.1 scenario jobs.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
features/test/php/scenarios.json |
Removes PHP 8.1 per-feature scenario definitions. |
features/test/_global/scenarios.json |
Removes PHP 8.1 global scenario definitions. |
features/src/xdebug/install.sh |
Drops PHP 8.1 install branches and fixes Alpine ini cleanup paths for 8.2–8.4. |
features/src/xdebug/devcontainer-feature.json |
Bumps Xdebug feature version to reflect support changes. |
features/src/php/install.sh |
Removes PHP 8.1 install logic and updates version dispatch to 8.2+. |
features/src/php/devcontainer-feature.json |
Updates allowed PHP versions to 8.2–8.4 and bumps feature major version. |
.github/workflows/features-scenarios.yml |
Removes PHP 8.1 scenario workflow entries. |
.github/workflows/features-global.yml |
Removes PHP 8.1 global scenario workflow entries. |
Comments suppressed due to low confidence (1)
features/src/php/install.sh:485
- Same issue on Alpine: "8.0"/"8.1" are still accepted but PHP 8.2 is installed/configured without normalizing PHP_VERSION. This can break follow-on features (e.g., xdebug reads /etc/dev-env-features/php) and reports the wrong installed version.
"8.0" | "8.1" | "8.2")
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 8 out of 8 changed files in this pull request and generated no new comments.
Comments suppressed due to low confidence (2)
features/src/php/install.sh:439
- The install script still accepts PHP 8.0/8.1 and silently coerces them to 8.2. If PHP 8.1 support is being removed and the feature schema only allows 8.2+, this should error instead of upgrading implicitly (otherwise misconfigurations are hidden and the implementation contradicts the stated support policy).
"8.0" | "8.1" | "8.2")
PHP_VERSION="8.2"
PHP_INI_DIR=/etc/php/8.2
setup_php82_deb
;;
features/src/php/install.sh:490
- The install script still accepts PHP 8.0/8.1 and silently coerces them to 8.2. With PHP 8.1 removed from supported versions, this branch should only match 8.2 and let 8.0/8.1 fall into the unsupported case.
"8.0" | "8.1" | "8.2")
PHP_VERSION="8.2"
PHP_INI_DIR=/etc/php82
setup_php82_alpine
;;
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request drops support for PHP 8.1 across all features, tests, and scenarios, and updates the minimum supported PHP version to 8.2. It removes all code, test scenarios, and installation logic related to PHP 8.1, and updates the PHP and Xdebug feature versions accordingly.
Removal of PHP 8.1 support:
features/src/php/devcontainer-feature.json, and updated the default and allowed PHP versions to 8.2, 8.3, and 8.4.features/src/php/install.shfor both Alpine and Debian/Ubuntu. [1] [2] [3] [4]features/test/_global/scenarios.jsonandfeatures/test/php/scenarios.json. [1] [2] [3] [4] [5] [6].github/workflows/features-global.ymland.github/workflows/features-scenarios.yml. [1] [2]Xdebug and versioning updates:
With these changes, the codebase and CI pipelines now only support PHP 8.2 and above, simplifying maintenance and reducing the test matrix.