Repository navigation
fix(mariadb): address deprecations - #556
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the MariaDB devcontainer feature to align with MariaDB-specific tooling, replacing deprecated MySQL-named binaries/commands and adjusting the MariaDB test health check accordingly.
Changes:
- Switch initialization from
mysql_install_dbtomariadb-install-dbin MariaDB entrypoint/service templates. - Switch server execution from
mysqldtomariadbdacross templates. - Update the MariaDB test check to use
mariadb-adminand bump the feature version to1.4.1.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| features/test/mariadb/checks.sh | Updates health check command and changes startup wait logic for MariaDB readiness. |
| features/src/mariadb/service-run.tpl | Uses mariadb-install-db and runs mariadbd under runit. |
| features/src/mariadb/entrypoint.deb.tpl | Uses mariadb-install-db and runs mariadbd for Debian-based images. |
| features/src/mariadb/entrypoint.alpine.tpl | Uses mariadb-install-db and runs mariadbd for Alpine-based images. |
| features/src/mariadb/devcontainer-feature.json | Bumps feature version to reflect the change set. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the MariaDB devcontainer feature to use the correct MariaDB-specific binaries and commands, ensuring better compatibility and alignment with upstream MariaDB. It also improves the test script to use the proper MariaDB client tools and makes the startup check more robust.
MariaDB binary and command alignment:
mysql_install_dbwithmariadb-install-dbin entrypoint and service scripts to use the MariaDB-specific initialization tool. [1] [2] [3]mysqldtomariadbdfor consistency with MariaDB best practices. [1] [2] [3] [4]Testing improvements:
checks.sh) to usemariadb-admininstead ofmysqladminfor health checks, and improved the wait loop to ensure MariaDB is online before proceeding. [1] [2]Version update:
devcontainer-feature.jsonfrom1.4.0to1.4.1to reflect these changes.