Skip to content

fix(vip-cli): vip-cli may require a compiler - #580

Merged
sjinks merged 3 commits into
trunkfrom
fix-vip-cli
Oct 4, 2026
Merged

sjinks merged 3 commits into
trunkfrom
fix-vip-cli

Conversation

@sjinks

@sjinks sjinks commented Oct 4, 2026

Copy link
Copy Markdown
Member

This pull request updates the vip-cli devcontainer feature to improve the installation process and handle required dependencies more robustly. The key changes include updating the feature version, refining dependency installation, and ensuring temporary build tools are cleaned up after installation.

Dependency installation improvements:

  • The script now ensures g++ is installed if not already present, which is necessary for building some Node.js dependencies. After installation, g++ is removed to keep the image lean.
  • The script no longer checks for the presence of node, npm, or npx before installing them; it simply ensures the relevant packages are installed for both Debian- and Alpine-based systems, simplifying the logic. [1] [2]

Version update:

  • The devcontainer-feature.json version is bumped from 1.5.0 to 1.5.1 to reflect these improvements.

@sjinks sjinks self-assigned this Oct 4, 2026
Copilot AI balanced review requested due to automatic review settings October 4, 2026 03:32

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

Native-build prerequisites remain incomplete, and Debian cleanup leaves compiler dependencies installed.

Review effort: Balanced
Findings: 2 Medium severity

Open (2)
What changed in this PR

Updates the vip-cli devcontainer feature to support native dependency compilation during installation.

Changes:

  • Adds conditional compiler installation and cleanup.
  • Removes redundant inner Node.js dependency checks.
  • Bumps the feature version to 1.5.1.
File Description
features/​src/​vip-cli/​install.sh Adjusts dependency installation and adds temporary compiler handling.
features/​src/​vip-cli/​devcontainer-feature.json Bumps the feature patch version.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread features/src/vip-cli/install.sh Outdated
Comment thread features/src/vip-cli/install.sh Outdated
@sjinks
sjinks force-pushed the fix-vip-cli branch 2 times, most recently from cd78e2c to 76eee0e Compare October 4, 2026 03:53
@sjinks
sjinks merged commit 7298c67 into trunk Oct 4, 2026
159 checks passed
@sjinks
sjinks deleted the fix-vip-cli branch October 4, 2026 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants