Repository navigation
fix(vip-cli): vip-cli may require a compiler - #580
Merged
Merged
Conversation
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Native-build prerequisites remain incomplete, and Debian cleanup leaves compiler dependencies installed.
Review effort: Balanced
Findings: 2
Open (2)
What changed in this PR
Updates the vip-cli devcontainer feature to support native dependency compilation during installation.
Changes:
- Adds conditional compiler installation and cleanup.
- Removes redundant inner Node.js dependency checks.
- Bumps the feature version to
1.5.1.
| File | Description |
|---|---|
| features/src/vip-cli/install.sh | Adjusts dependency installation and adds temporary compiler handling. |
| features/src/vip-cli/devcontainer-feature.json | Bumps the feature patch version. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
sjinks
force-pushed
the
fix-vip-cli
branch
2 times, most recently
from
October 4, 2026 03:53
cd78e2c to
76eee0e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

This pull request updates the
vip-clidevcontainer feature to improve the installation process and handle required dependencies more robustly. The key changes include updating the feature version, refining dependency installation, and ensuring temporary build tools are cleaned up after installation.Dependency installation improvements:
g++is installed if not already present, which is necessary for building some Node.js dependencies. After installation,g++is removed to keep the image lean.node,npm, ornpxbefore installing them; it simply ensures the relevant packages are installed for both Debian- and Alpine-based systems, simplifying the logic. [1] [2]Version update:
devcontainer-feature.jsonversion is bumped from1.5.0to1.5.1to reflect these improvements.