chore: migrate vitest and coverage-v8 to v5 - #933
Merged
Merged
Conversation
- Bump vitest and @vitest/coverage-v8 from ^4.1.11 to ^5.0.0 - Update vitest.config.ts: import from vitest/config, remove triple-slash reference, add explicit reportsDirectory to keep coverage path stable - Add .vitest/ to .gitignore for new v5 artifact directory Fix DOM prop warnings (shouldForwardProp): - Disclaimer: add shouldForwardProp for accent/dense on AvDisclaimer styled div - Disclaimer: add descriptionComponent prop to allow callers to override the Typography wrapper element (used by SpacesDisclaimer when markdown=true) - FavoriteHeart: add shouldForwardProp for customSize on all three styled components (FavoriteHeartContainer, FavoriteInput, FavoriteIcon) Fix source bugs: - MultiPayerModal: add missing key prop on mapped payer space Box elements - SpacesDisclaimer: pass descriptionComponent='div' when markdown=true to prevent invalid <h1> inside <p> hydration error Fix test setup issues: - Table tests (7 files): wrap sub-components in valid HTML ancestor structure to eliminate React 19 hydration warnings - FeedbackForm.test: switch to userEvent.setup() + await, flush autoFocus ripple with act() to eliminate act() warnings - Select.test: pass value='' on uncontrolled render to avoid MUI out-of-range warning - StepContent.test: stub ResizeObserver and wrap in vertical Stepper context to eliminate MUI design-usage warning All 163 test files (381 tests) pass with zero stderr warnings.
jordan-a-young
requested review from
LauRoxx and
gregmartDOTin
as code owners
September 14, 2026 21:21
Contributor
|
🚀 Preview deployed! |
- Move Nx cache restore before yarn install in all jobs - Add NX_DAEMON=false to prevent daemon fork attempts in CI - Upload build artifacts in setup job, download in downstream jobs to avoid redundant rebuilds across publish and deploy-docs - Parallelize deploy-docs with publish by depending on setup instead of waiting for publish to complete
Add Node 24 setup with yarn cache before yarn install, matching the pattern in sdk-js repo-metrics.yml
Only breaking change in jsdom 30 is Node.js minimum raised to ^22.22.2 || ^24.15.0 || >=26.0.0, which is satisfied by CI matrix. All 381/974/729 tests passing.
- actions/upload-artifact: v4 (floating) -> v7.0.1 (SHA pinned) - actions/download-artifact: v4 (floating) -> v8.0.1 (SHA pinned) - actions/upload-pages-artifact: v3.0.1 -> v5.0.0 - actions/deploy-pages: v4.0.5 -> v5.0.1 All updated versions run on Node.js 24, eliminating the Node.js 20 deprecation warnings seen in CI. Also pins floating @v4 tags to exact SHAs for consistency with the rest of the workflow files.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Migrates
vitestand@vitest/coverage-v8from^4.1.11to^5.0.0and cleans up all resulting test warnings.Changes
Dependency upgrades
vitest→5.0.0@vitest/coverage-v8→5.0.0Config
vitest.config.ts: import fromvitest/config, remove triple-slash reference, add explicitreportsDirectory: './coverage'to keep coverage path stable.gitignore: add.vitest/for vitest v5's new artifact directorySource bug fixes
MultiPayerModal: add missingkeyprop on mapped payer spaceBoxelementsDisclaimer: addshouldForwardPropforaccent/denseto prevent boolean props leaking to the DOM; adddescriptionComponentprop so callers can override the Typography wrapper elementSpacesDisclaimer: passdescriptionComponent="div"whenmarkdown={true}to prevent invalid<h1>inside<p>hydration errorFavoriteHeart: addshouldForwardPropforcustomSizeon all three styled components to prevent it reaching the DOMTest fixes
FeedbackForm.test: switch touserEvent.setup()+await, flushautoFocusripple withact()Select.test: passvalue=""on uncontrolled render to avoid MUI out-of-range warningStepContent.test: stubResizeObserverand wrap in verticalSteppercontextTest Results
All 163 test files (381 tests) pass with zero stderr warnings.