Repository navigation
Conversation
Contributor
Windows Unit Test Results 3 files 18 suites 1m 13s ⏱️ Results for commit 41197f5. ♻️ This comment has been updated with latest results. |
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The narrow change matches the stated publication status and restores regression coverage without changing other image mappings.
0 open findings
What changed in this PR
Restores ACL CVM Gen2 to AgentBaker’s maintained Linux image configurations, removing the temporary exclusion introduced in #9705 now that the image is reported built and published.
Changes:
- Removes
aclgen2CVMfrom the skip list. - Restores the corresponding test expectation.
| File | Description |
|---|---|
| pkg/agent/datamodel/sig_config.go | Includes ACL CVM Gen2 in maintained image configurations. |
| pkg/agent/datamodel/sig_config_test.go | Restores the ACL CVM Gen2 expectation. |
🧠 Review effort: Balanced
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
aadhar-agarwal
approved these changes
Oct 20, 2026
Cameron Meissner (cameronmeissner)
approved these changes
Oct 20, 2026
Contributor
|
mayankfz you need a rebase |
Rebased onto main, preserving the ACL Kata image exclusion. Co-authored-by: Mayan Singh <mayankfz@gmail.com> Signed-off-by: Aadhar Agarwal <aadagarwal@microsoft.com>
aadhar-agarwal
force-pushed
the
mayansingh/enable-acl-cvm-sig-image
branch
from
October 21, 2026 00:50
1a2a552 to
41197f5
Compare
Contributor
Mayank is OOF for a couple days, just rebased this one |
Contributor
|
Contributor
|
Contributor
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Removes aclgen2CVM from the definitionsToSkip list in GetMaintainedLinuxSIGImageConfigMap and restores its test expectation, now that the ACL CVM Gen2 VHD is built and published, reverting the temporary skip added in #9705.
Which issue(s) this PR fixes:
Fixes #