Repository navigation
fix: configure packages endpoints when repo depot is set - #9828
Merged
Merged
Conversation
Contributor
Windows Unit Test Results 3 files 18 suites 1m 2s ⏱️ Results for commit cabf37c. ♻️ This comment has been updated with latest results. |
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Repository initialization failures can now skip certificate-refresh scheduling while provisioning continues.
1 open issue
What changed in this PR
Configures Linux RepoDepot endpoints independently of certificate-refresh opt-in during node provisioning.
Changes:
- Moves repository initialization before the certificate-scheduling guard.
- Removes cloud-init completion waits.
- Adds dispatch tests across distributions, endpoint settings, and failure paths.
| File | Description |
|---|---|
| spec/parts/linux/cloud-init/artifacts/init_aks_cloud_spec.sh | Tests repository dispatch and scheduling boundaries. |
| parts/linux/cloud-init/artifacts/init-aks-cloud.sh | Decouples repository setup from certificate opt-in. |
Review effort: Balanced
Nishchay (awesomenix)
force-pushed
the
nishp/pin/containerd
branch
from
October 20, 2026 15:04
5f0ef17 to
3b4c447
Compare
Nishchay (awesomenix)
force-pushed
the
nishp/pin/containerd
branch
from
October 20, 2026 15:05
3b4c447 to
cabf37c
Compare
Contributor
|
Contributor
|
Contributor
|
| ubuntuRel=$(lsb_release --release | awk '{print $2}') | ||
| ubuntuDist=$(lsb_release -c | awk '{print $2}') | ||
| init_ubuntu_main_repo_depot ${rootRepoDepotEndpoint} | ||
| init_ubuntu_pmc_repo_depot ${rootRepoDepotEndpoint} |
Cameron Meissner (cameronmeissner)
approved these changes
Oct 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sometimes some crazy clouds dont want to opt into downloading root certs, configure repo depot endpont regardless if the endpoint is set