Repository navigation
Conversation
Contributor
Windows Unit Test Results 3 files 18 suites 1m 1s ⏱️ Results for commit 93247f5. |
Contributor
|
Contributor
|
Contributor
|
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Unbounded APT retry duration and suppressed cache-refresh failures introduce provisioning regressions.
2 open issues
What changed in this PR
Decouples RepoDepot initialization from certificate-download opt-in during Linux node provisioning.
Changes:
- Registers eligible certificate-refresh schedules before repository setup.
- Revises package-cache retries and failure handling.
- Adds ShellSpec coverage for dispatch, scheduling, and retry behavior.
| File | Description |
|---|---|
| spec/parts/linux/cloud-init/artifacts/init_aks_cloud_spec.sh | Tests independent initialization gates and cache retries. |
| parts/linux/cloud-init/artifacts/init-aks-cloud.sh | Separates scheduling from repository setup and revises cache updates. |
Review effort: Balanced
Comment on lines
+427
to
+429
| for i in $(seq 1 "$retries"); do | ||
| echo "Running apt-get update (attempt $i/$retries)" | ||
| if apt-get update; then |
Comment on lines
+720
to
+730
| aptget_update || true | ||
| elif [ "$IS_MARINER" -eq 1 ] || [ "$IS_AZURELINUX" -eq 1 ]; then | ||
| if [ "$IS_MARINER" -eq 1 ]; then | ||
| echo "Initializing Mariner repo depot settings..." | ||
| init_mariner_repo_depot ${rootRepoDepotEndpoint} | ||
| else | ||
| echo "Initializing Azure Linux repo depot settings..." | ||
| init_azurelinux_repo_depot ${rootRepoDepotEndpoint} | ||
| fi | ||
| echo "Running dnf_makecache" | ||
| dnf_makecache || true |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
keep scheduling and repository initialization independently gated so custom cloud's don't need to opt-in to root cert download. eligible nodes register certificate refresh before repository setup.
Which issue(s) this PR fixes:
Fixes #