Repository navigation
fix: configure packages endpoints when repo depot is set (#9828) - #9838
Merged
Nishchay (awesomenix) merged 3 commits intoOct 20, 2026
Merged
Conversation
aks-node-assistant
Bot
requested review from
Devinwong,
Cameron Meissner (cameronmeissner),
Sylvain Boily (djsly),
lilypan26,
Artur Khantimirov (r2k1) and
Tim Wright (timmy-wright)
as code owners
October 20, 2026 22:32
Contributor
Windows Unit Test Results 3 files 18 suites 1m 5s ⏱️ Results for commit 0fae8c0. |
Contributor
|
Contributor
|
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Repository failures can prevent certificate-refresh scheduling, and APT retries can accept incomplete metadata downloads as success.
2 open issues
What changed in this PR
This cherry-pick fixes RepoDepot initialization for Delos by separating package repository setup from certificate-refresh eligibility.
Changes:
- Moves repository initialization before the certificate scheduling guard and removes the cloud-init wait.
- Updates package-cache retries and adds ShellSpec coverage.
- Adds hotfix metadata and generated cloud-config artifacts.
| File | Description |
|---|---|
spec/parts/linux/cloud-init/artifacts/init_aks_cloud_spec.sh |
Tests repository dispatch and cache retries. |
parts/linux/cloud-init/nodecustomdata.yml |
Adds the custom-cloud script hotfix entry. |
parts/linux/cloud-init/artifacts/init-aks-cloud.sh |
Separates repository initialization and updates retries. |
parts/linux/cloud-init/artifacts/aks-node-controller-hotfix.json |
Sets the scripts hotfix version. |
aks-node-controller/generated/rendered_nodecustomdata_ubuntu.yml |
Adds an empty Ubuntu cloud-config skeleton. |
aks-node-controller/generated/rendered_nodecustomdata_mariner.yml |
Adds an empty Mariner cloud-config skeleton. |
aks-node-controller/generated/README |
Removes the generated-directory placeholder. |
Review effort: Balanced
Comment on lines
+429
to
+432
| if apt-get update; then | ||
| echo "apt-get update complete!" | ||
| return 0 | ||
| fi |
| ubuntuRel=$(lsb_release --release | awk '{print $2}') | ||
| ubuntuDist=$(lsb_release -c | awk '{print $2}') | ||
| init_ubuntu_main_repo_depot ${rootRepoDepotEndpoint} | ||
| init_ubuntu_pmc_repo_depot ${rootRepoDepotEndpoint} |
Cameron Meissner (cameronmeissner)
approved these changes
Oct 20, 2026
Contributor
|
| @@ -0,0 +1,4 @@ | |||
| #cloud-config | |||
| write_files: | |||
Contributor
There was a problem hiding this comment.
sad
Nishchay (awesomenix)
had a problem deploying
to
test
October 20, 2026 22:42 — with 
GitHub Actions
Failure
GitHub Actions
Failure
Nishchay (awesomenix)
merged commit Oct 20, 2026
47300f8
into
official/v20261016
11 of 14 checks passed
This branch had an error being deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cherry-pick repo depot fix for delos