Repository navigation
Conversation
Render and select AKS custom-cloud payload variants from live provisioning inputs. Avoid reinjecting canonical scriptless entries that already exist. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 9b42051a-f79c-4dbf-8460-a4772d54e01f
Keep the existing renderer loop with explicit cloud targets and consolidate regression cases while retaining runtime eligibility protection. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 9b42051a-f79c-4dbf-8460-a4772d54e01f
Remove runtime cloud selection and duplicate-block changes. Skip rendered YAML without write_files entries, remove stale empty outputs, and retain an embed placeholder when all platforms are empty. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 9b42051a-f79c-4dbf-8460-a4772d54e01f
Contributor
Windows Unit Test Results 3 files 18 suites 48s ⏱️ Results for commit 244cadb. ♻️ This comment has been updated with latest results. |
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The focused generation-only change has targeted regression coverage and no identified blocking issues.
No open issues 🎉
What changed in this PR
Prevents empty hotfix payloads from being generated while preserving go:embed compatibility and existing runtime eligibility.
Changes:
- Skips and removes platform YAMLs without
write_filesentries. - Writes a README placeholder when all platforms are empty.
- Adds regression coverage and documents the behavior.
| File | Description |
|---|---|
| hotfix/render-nodecustomdata/main.go | Filters empty payloads and creates the placeholder. |
| hotfix/hotfix_generate_test.py | Covers payload filtering, stale-file removal, and embedding. |
| aks-node-controller/README.md | Documents empty-payload handling. |
Review effort: Balanced
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 9b42051a-f79c-4dbf-8460-a4772d54e01f
Contributor
|
Contributor
|
Contributor
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Skip rendered hotfix YAML without
write_filesentries; retain a README when all platforms are empty sogo:embedbuilds. Includes regression coverage. No runtime eligibility changes.Which issue(s) this PR fixes:
N/A