Repository navigation
Configure artifact streaming before starting services - #9843
Open
Julius Liu (juliusl) with Copilot wants to merge 2 commits into
Open
Julius Liu (juliusl) with Copilot wants to merge 2 commits into
Julius Liu (juliusl) with Copilot wants to merge 2 commits into
Conversation
Co-authored-by: juliusl <5741075+juliusl@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix artifact streaming race condition before setup runs
Configure artifact streaming before starting services
Oct 21, 2026
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
Static review found no blocking issues, and targeted regression assertions cover both package paths; tests were not executed.
No open issues 🎉
What changed in this PR
Fixes #9842 by configuring artifact streaming before starting services during Linux node provisioning.
Changes:
- Runs modern or legacy setup before service startup.
- Aborts on setup failure while preserving service-start retries.
- Adds regression coverage for ordering and failure handling.
| File | Description |
|---|---|
| spec/parts/linux/cloud-init/artifacts/cse_config_gpu_spec.sh | Tests startup ordering and failure paths. |
| parts/linux/cloud-init/artifacts/cse_config.sh | Moves setup before startup and checks setup failures. |
Review effort: Balanced
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Artifact streaming services started before mirror setup completed, allowing acr-mirror to miss settings such as the
docker.io→registry-1.docker.iorewrite until node restart.setup.sh aksor legacyacr-configbefore starting acr-mirror and overlaybd services.