Skip to content

feat: move report ready to golang - #9848

Merged
Nishchay (awesomenix) merged 1 commit into
mainfrom
nishp/make/report_ready_go
Oct 21, 2026
Merged

Nishchay (awesomenix) merged 1 commit into
mainfrom
nishp/make/report_ready_go

Conversation

@awesomenix

Copy link
Copy Markdown
Contributor

as title says, makes it simpler

Copilot AI balanced review requested due to automatic review settings October 21, 2026 16:45
@awesomenix
Nishchay (awesomenix) requested review from a team as code owners October 21, 2026 16:45
@github-actions

github-actions Bot commented Oct 21, 2026 •

Copy link
Copy Markdown
Contributor

Windows Unit Test Results

  3 files   18 suites   1m 14s ⏱️
563 tests 563 ✅ 0 💤 0 ❌
585 runs  585 ✅ 0 💤 0 ❌

Results for commit 56f301d.

♻️ This comment has been updated with latest results.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

Provisioning-critical reporting changes need human confirmation of Azure fabric interoperability and compatibility across supported images.

No open issues 🎉

What changed in this PR

Moves Azure provisioning-status reporting from Python into aks-node-controller, simplifying Linux node readiness reporting.

Changes:

  • Adds native Go health reporting, Hyper-V diagnostics, retries, and unit tests.
  • Removes the Python reporter from Linux image builds.
  • Updates readiness handoff logic, documentation, and end-to-end log validation.
File Description
vhdbuilder/​packer/​vhd-image-builder-mariner.json Removes Python reporter upload.
vhdbuilder/​packer/​vhd-image-builder-mariner-cvm.json Removes Python reporter upload.
vhdbuilder/​packer/​vhd-image-builder-mariner-arm64.json Removes Python reporter upload.
vhdbuilder/​packer/​vhd-image-builder-cvm.json Removes Python reporter upload.
vhdbuilder/​packer/​vhd-image-builder-base.json Removes Python reporter upload.
vhdbuilder/​packer/​vhd-image-builder-arm64-gen2.json Removes Python reporter upload.
vhdbuilder/​packer/​vhd-image-builder-arm64-gb.json Removes Python reporter upload.
vhdbuilder/​packer/​vhd-image-builder-acl.json Removes Python reporter upload.
vhdbuilder/​packer/​vhd-image-builder-acl-arm64.json Removes Python reporter upload.
vhdbuilder/​packer/​packer_source.sh Removes Python reporter installation.
vhdbuilder/​packer/​imagecustomizer/​azlosguard/​azlosguard.yml Removes Python reporter packaging.
pkg/​agent/​baker.go Removes Python availability guard from readiness handoff.
pkg/​agent/​baker_test.go Updates handoff assertions.
parts/​linux/​cloud-init/​artifacts/​report_ready.py Deletes the Python reporter.
e2e/​scenario/​validators.go Checks the native controller log.
aks-node-controller/​README.md Documents native reporting behavior.
aks-node-controller/​pkg/​nodeconfigutils/​utils.go Updates readiness handoff guard.
aks-node-controller/​pkg/​nodeconfigutils/​utils_test.go Updates handoff assertions.
aks-node-controller/​goal_state.go Implements native health reporting and diagnostics.
aks-node-controller/​goal_state_test.go Tests protocol handling, retries, and encoding.
aks-node-controller/​const.go Removes the Python script path constant.
aks-node-controller/​app.go Calls the native reporter.
aks-node-controller/​app_test.go Updates reporting integration tests.

Review effort: Balanced

Copilot AI balanced review requested due to automatic review settings October 21, 2026 17:02
@github-actions

Copy link
Copy Markdown
Contributor

Code Coverage

Package Line Rate Health
parts_windows Package 1 73% ➖
staging_cse_windows Package 1 65% ➖
debug 0% ❌
provisioningscripts 2% ❌
test 0% ❌
windows 27% ❌
Summary 38% (1652 / 6834) ❌

@github-actions

Copy link
Copy Markdown
Contributor

Code Coverage

Package Line Rate Health
github.com/Azure/agentbaker/aks-node-controller 72% ➖
github.com/Azure/agentbaker/aks-node-controller/common 100% ✔
github.com/Azure/agentbaker/aks-node-controller/helpers 68% ➖
github.com/Azure/agentbaker/aks-node-controller/parser 88% ✔
github.com/Azure/agentbaker/aks-node-controller/pkg/gpu 100% ✔
github.com/Azure/agentbaker/aks-node-controller/pkg/nodeconfigutils 89% ✔
github.com/Azure/agentbaker/aks-node-controller/utils 0% ❌
github.com/Azure/agentbaker/apiserver 24% ❌
github.com/Azure/agentbaker/cmd 0% ❌
github.com/Azure/agentbaker/cmd/starter 0% ❌
github.com/Azure/agentbaker/fuzz/api 0% ❌
github.com/Azure/agentbaker/hotfix/render-nodecustomdata 0% ❌
github.com/Azure/agentbaker/pkg/agent 78% ➖
github.com/Azure/agentbaker/pkg/agent/datamodel 77% ➖
github.com/Azure/agentbaker/pkg/agent/toggles 0% ❌
github.com/Azure/agentbaker/pkg/vhdbuilder/datamodel 87% ✔
Summary 75% (5833 / 7808) ➖

@github-actions

Copy link
Copy Markdown
Contributor

Code Coverage

Package Line Rate Health
shellspec spec 28% ❌
Summary 28% (4556 / 15971) ❌

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

Replacing the readiness reporter requires human validation of success and failure reporting across supported VHDs.

No open issues 🎉

Review effort: Balanced

@awesomenix
Nishchay (awesomenix) merged commit 524bb79 into main Oct 21, 2026
37 of 41 checks passed
@awesomenix
Nishchay (awesomenix) deleted the nishp/make/report_ready_go branch October 21, 2026 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants