Repository navigation
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: fbca5989-e009-4aeb-a8e6-2e6bbb96b493
Contributor
Windows Unit Test Results 3 files 18 suites 1m 9s ⏱️ Results for commit 68a9e62. |
Contributor
Contributor
|
Contributor
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The scoped E2E parameterization preserves existing defaults and has no identified blocking issues; live cloud validation remains unperformed.
No open issues 🎉
What changed in this PR
Parameterizes AgentBaker’s existing ANC hotfix E2E scenarios to validate an exact published package while preserving the fixed-version regression default.
Changes:
- Adds CLI and environment inputs with version validation before Azure initialization.
- Shares resolved versions across binary compilation, fixture injection, and assertions.
- Updates tests and documents release-validation inputs and constraints.
| File | Description |
|---|---|
| spec/e2e/e2e_runner_scripts_spec.sh | Tests input defaults and forwarding. |
| e2e/scenario/vmss.go | Passes resolved versions into compilation and fixtures. |
| e2e/scenario/scenario_anc_hotfix.go | Uses resolved versions in assertions. |
| e2e/scenario/scenario_anc_hotfix_test.go | Tests fixtures with multiple targets. |
| e2e/runner/filter_test.go | Checks rejection before Azure initialization. |
| e2e/runner/app.go | Resolves versions before run setup. |
| e2e/README.md | Documents package validation and pipeline inputs. |
| e2e/config/flags.go | Exposes hotfix validation flags and environment inputs. |
| e2e/config/config.go | Stores hotfix settings and defaults. |
| e2e/config/anc_hotfix.go | Validates targets and derives base versions. |
| e2e/config/anc_hotfix_test.go | Tests resolution, parsing, and pipeline input preservation. |
| .pipelines/scripts/e2e_run.sh | Exports hotfix inputs with backward-compatible defaults. |
Review effort: Balanced
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
go test ./config ./runner -count=1go vet ./config ./runner ./scenarioNo live cloud E2E was run.