Skip to content

test: support validating published ANC hotfix version in e2e test - #9852

Open
Devinwong wants to merge 1 commit into
mainfrom
devinwong-anc-hotfix-e2e-validation
Open

Devinwong wants to merge 1 commit into
mainfrom
devinwong-anc-hotfix-e2e-validation

Conversation

@Devinwong

Copy link
Copy Markdown
Collaborator

Summary

  • Parameterize the existing ANC hotfix E2E flow with the exact ANC package version published by orchestration.
  • Exercise the real node-side repository download path and assert the expected hotfix binary is downloaded, selected, and executed without package-manager fallback.
  • Preserve the fixed-version ANC regression scenario for ordinary runs; require an explicit target when release validation is requested.
  • Document the pipeline inputs and behavior.

Validation

  • go test ./config ./runner -count=1
  • go vet ./config ./runner ./scenario
  • ShellSpec e2e runner script tests (5 examples)
  • Focused ANC scenario/fixture tests

No live cloud E2E was run.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot-Session: fbca5989-e009-4aeb-a8e6-2e6bbb96b493
Copilot AI balanced review requested due to automatic review settings October 21, 2026 20:09
@Devinwong
Devinwong requested review from a team as code owners October 21, 2026 20:09
@github-actions

Copy link
Copy Markdown
Contributor

Windows Unit Test Results

  3 files   18 suites   1m 9s ⏱️
563 tests 563 ✅ 0 💤 0 ❌
585 runs  585 ✅ 0 💤 0 ❌

Results for commit 68a9e62.

@github-actions

Copy link
Copy Markdown
Contributor

Code Coverage

Package Line Rate Health
test 0% ❌
windows 27% ❌
staging_cse_windows Package 1 65% ➖
debug 0% ❌
provisioningscripts 2% ❌
parts_windows Package 1 73% ➖
Summary 38% (1652 / 6834) ❌

@github-actions

Copy link
Copy Markdown
Contributor

Code Coverage

Package Line Rate Health
github.com/Azure/agentbaker/aks-node-controller 72% ➖
github.com/Azure/agentbaker/aks-node-controller/common 100% ✔
github.com/Azure/agentbaker/aks-node-controller/helpers 68% ➖
github.com/Azure/agentbaker/aks-node-controller/parser 88% ✔
github.com/Azure/agentbaker/aks-node-controller/pkg/gpu 100% ✔
github.com/Azure/agentbaker/aks-node-controller/pkg/nodeconfigutils 89% ✔
github.com/Azure/agentbaker/aks-node-controller/utils 0% ❌
github.com/Azure/agentbaker/apiserver 24% ❌
github.com/Azure/agentbaker/cmd 0% ❌
github.com/Azure/agentbaker/cmd/starter 0% ❌
github.com/Azure/agentbaker/fuzz/api 0% ❌
github.com/Azure/agentbaker/hotfix/render-nodecustomdata 0% ❌
github.com/Azure/agentbaker/pkg/agent 78% ➖
github.com/Azure/agentbaker/pkg/agent/datamodel 77% ➖
github.com/Azure/agentbaker/pkg/agent/toggles 0% ❌
github.com/Azure/agentbaker/pkg/vhdbuilder/datamodel 87% ✔
Summary 74% (5833 / 7825) ➖

@github-actions

Copy link
Copy Markdown
Contributor

Code Coverage

Package Line Rate Health
shellspec spec 28% ❌
Summary 28% (4556 / 15973) ❌

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The scoped E2E parameterization preserves existing defaults and has no identified blocking issues; live cloud validation remains unperformed.

No open issues 🎉

What changed in this PR

Parameterizes AgentBaker’s existing ANC hotfix E2E scenarios to validate an exact published package while preserving the fixed-version regression default.

Changes:

  • Adds CLI and environment inputs with version validation before Azure initialization.
  • Shares resolved versions across binary compilation, fixture injection, and assertions.
  • Updates tests and documents release-validation inputs and constraints.
File Description
spec/​e2e/​e2e_runner_scripts_spec.sh Tests input defaults and forwarding.
e2e/​scenario/​vmss.go Passes resolved versions into compilation and fixtures.
e2e/​scenario/​scenario_anc_hotfix.go Uses resolved versions in assertions.
e2e/​scenario/​scenario_anc_hotfix_test.go Tests fixtures with multiple targets.
e2e/​runner/​filter_test.go Checks rejection before Azure initialization.
e2e/​runner/​app.go Resolves versions before run setup.
e2e/​README.md Documents package validation and pipeline inputs.
e2e/​config/​flags.go Exposes hotfix validation flags and environment inputs.
e2e/​config/​config.go Stores hotfix settings and defaults.
e2e/​config/​anc_hotfix.go Validates targets and derives base versions.
e2e/​config/​anc_hotfix_test.go Tests resolution, parsing, and pipeline input preservation.
.pipelines/​scripts/​e2e_run.sh Exports hotfix inputs with backward-compatible defaults.

Review effort: Balanced

@Devinwong Devinwong changed the title e2e: validate published ANC hotfix version test: validate published ANC hotfix version Oct 21, 2026
@Devinwong Devinwong changed the title test: validate published ANC hotfix version test: validate published ANC hotfix version in e2e test Oct 21, 2026
@Devinwong Devinwong changed the title test: validate published ANC hotfix version in e2e test test: support validating published ANC hotfix version in e2e test Oct 21, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants