Repository navigation
fix(e2e): preserve LocalDNS kubelet configuration parity - #9859
Merged
Nishchay (awesomenix) merged 1 commit intoOct 22, 2026
Merged
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
Windows Unit Test Results 3 files 18 suites 1m 10s ⏱️ Results for commit ee9af9c. |
Contributor
Contributor
Contributor
|
Nishchay (awesomenix)
approved these changes
Oct 22, 2026
Nishchay (awesomenix)
marked this pull request as ready for review
October 22, 2026 01:17
Nishchay (awesomenix)
requested review from
a team,
Saewon Kwak (saewoni) and
Ye Wang (yewmsft)
as code owners
October 22, 2026 01:17
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The narrow E2E changes match the existing conversion contract, with no blocking defects identified; tests were not executed.
No open issues 🎉
What changed in this PR
This PR aligns LocalDNS E2E kubelet settings with the selected configuration mode, preserving parity between CSE and aks-node-controller provisioning.
Changes:
- Set
ClusterDnswhen kubelet config files are enabled; otherwise set--cluster-dns. - Add a regression test verifying that LocalDNS mutators preserve config-file settings without reintroducing the flag.
| File | Description |
|---|---|
e2e/scenario/scenario_localdns_hosts.go |
Selects the appropriate DNS setting for hosts-plugin scenarios. |
e2e/scenario/scenario_localdns_fallback.go |
Applies the same configuration-mode handling to fallback scenarios. |
e2e/scenario/node_config_test.go |
Adds LocalDNS config-file parity assertions. |
Review effort: Balanced
Nishchay (awesomenix)
deleted the
sharsha/fix-localdns-kubelet-config-parity
branch
October 22, 2026 01:39
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #