Change character validation in tag key to align with server behavior - #2581
Change character validation in tag key to align with server behavior#2581EmmaZhu-MSFT (EmmaZhu) wants to merge 2 commits into
Conversation
5ff6c7c to
59a059c
Compare
|
It seems the failing test is correct:
So I guess it needs separate validation for double quote delimited tag keys, and only then allow |
59a059c to
2be1279
Compare
There was a problem hiding this comment.
Pull request overview
This PR updates Azurite’s blob tag filter condition parsing to accept quoted tag keys with a broader set of characters, aligning the emulator’s behavior with Azure Storage server behavior. It also adds test coverage and a changelog entry for the behavior change.
Changes:
- Allow quoted tag keys to include spaces and specific special characters when parsing tag filter conditions.
- Add tests covering quoted keys with special characters and an additional invalid-key scenario.
- Document the behavior change in
ChangeLog.md.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| tests/blob/apis/blob.test.ts | Adds tests for quoted tag keys containing special characters and another invalid header case. |
| src/blob/persistence/QueryInterpreter/QueryParser.ts | Updates tag key validation to permit a wider character set when the key is quoted. |
| ChangeLog.md | Adds an entry describing the new quoted-key behavior. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
2be1279 to
c651d8e
Compare
c651d8e to
ff6f8b1
Compare
|
EmmaZhu-MSFT (@EmmaZhu) please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
|
Thanks for contribution! Please go through following checklist before sending PR.
PR Branch Destination
mainbranch.legacy-devbranch.Always Add Test Cases
Make sure test cases are added to cover the code change.
Add Change Log
Add change log for the code change in
Upcoming Releasesection inChangeLog.md.Development Guideline
Please go to CONTRIBUTION.md for steps about setting up development environment and recommended Visual Studio Code extensions.