fix: close WSGI response iterables after consumption - #369
Open
Shubham Padkonde (Shubham-Padkonde) wants to merge 1 commit into
Open
Shubham Padkonde (Shubham-Padkonde) wants to merge 1 commit into
Shubham Padkonde (Shubham-Padkonde) wants to merge 1 commit into
Conversation
Shubham Padkonde (Shubham-Padkonde)
requested review from
Gavin Aguiar (gavin-aguiar),
hallvictoria and
Varad Meru (vrdmr)
as code owners
October 4, 2026 10:59
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The WSGI adapter consumes the application's response iterable without calling its
close()method. File responses can consequently leave their streams open, and framework cleanup callbacks are skipped.Close the original response iterable in a
finallyblock after consuming it, as required by PEP 3333. This also releases resources when iteration raises, while preserving the original iteration error when cleanup succeeds. Iterables withoutclose()continue to work.Validation: 890 tests pass and two are skipped on Python 3.13. New regressions cover a real Werkzeug file wrapper, an empty response, and an iteration error; all three fail before the fix. Flake8 E/F/W checks pass. The docstring plugin reports the same two pre-existing findings on the original and modified WSGI module.