Fix Compute capacity reservation assignment semantics by Copilot · Pull Request #30182 · Azure/azure-powershell

Copilot · 2026-09-22T15:35:32Z

🤖 PR Validation — ⚠️ Review suggested

Tests
⚠️ 66/66

️✔️Az.Accounts

⚠️Az.Compute

️✔️Az.KeyVault

️✔️Az.Maintenance

️✔️Az.ManagedServiceIdentity

️✔️Az.Monitor

️✔️Az.Network

️✔️Az.OperationalInsights

️✔️Az.PrivateDns

️✔️Az.RecoveryServices

️✔️Az.ResourceGraph

️✔️Az.Security

️✔️Az.Sql

️✔️Az.Ssh

️✔️Az.Storage

Capacity reservation assignment handling for VM and VMSS cmdlets conflated “parameter bound” with “switch enabled” and could not preserve explicit CRG removal intent. This updates validation and serialization so explicit false, explicit null, and omitted values have distinct behavior.

Validation
- Allow -CapacityReservationGroupId <id> with -DisableCapacityReservationAssignment:$false.
- Reject only non-null CRG ID with -DisableCapacityReservationAssignment:$true.
- Use a consistent error message across VM and VMSS paths.
Serialization
- Preserve explicit -CapacityReservationGroupId $null as an empty subresource for update removal:
```
"capacityReservationGroup": {}
```
- Avoid serializing { "id": null }.
- Keep omitted CRG ID behavior unchanged.
VMSS update paths
- Support -DisableCapacityReservationAssignment through both direct Update-AzVmss and object-based -VirtualMachineScaleSet update flows.
- Add VMSS update-profile capacity reservation serialization support.
Coverage and docs
- Added focused unit coverage for validation and serialization edge cases.
- Updated VM/VMSS scenario coverage, help text, and Compute changelog.

Example:

# Valid: explicit false does not opt out
New-AzVmssConfig `
  -CapacityReservationGroupId $crgId `
  -DisableCapacityReservationAssignment:$false

# Valid: explicit null removes the existing association on update
Update-AzVmss `
  -ResourceGroupName $rg `
  -VMScaleSetName $vmss `
  -CapacityReservationGroupId $null

# Invalid: true opt-out conflicts with a non-null CRG ID
Update-AzVM `
  -ResourceGroupName $rg `
  -VM $vm `
  -CapacityReservationGroupId $crgId `
  -DisableCapacityReservationAssignment

Verification Checklist

Fixes Save profile data in home directory #1577

Copilot

Copilot wasn't able to review any files in this pull request.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

azure-pipelines · 2026-09-22T15:35:50Z

Azure Pipelines: Successfully started running 2 pipeline(s). There may be pipelines that require an authorized user to comment /azp run to run.

Co-authored-by: haagha <64601174+haagha@users.noreply.github.com>

Copilot

Copilot wasn't able to review any files in this pull request.

Co-authored-by: haagha <64601174+haagha@users.noreply.github.com>

Copilot

Copilot review overview

🟡 Changes recommended

Two moderate create-config serialization issues remain, along with help and changelog corrections.

Get a fresh assessment by requesting another Copilot review.

Review effort: Lite
Findings: 1

Open (1)

Use the repository's standard changelog issue-reference format · New

Copilot

Copilot review overview

🟡 Changes recommended

Unresolved moderate validation, serialization, and end-to-end coverage issues remain, along with documentation nits.

Get a fresh assessment by requesting another Copilot review.

Review effort: Lite
Findings: 2

Open (2)

Test VMSS PATCH and PUT removal of capacity reservation groups · New
Add Update-AzVM coverage for capacity reservation changes · New

Resolved since last review (1)

Use the repository's standard changelog issue-reference format

Previously missed (1)

In code that hasn't changed since last review

Correct or remove unrelated Fixes #1577 reference

src/Compute/Compute/ChangeLog.md:23

The PR description's Fixes #1577 reference does not match this change: repository item #1577 is the unrelated closed pull request titled Save profile data in home directory. Please replace or remove that closing reference so the capacity-reservation change points to the correct issue.

+                    CapacityReservationAssignmentHelper.CreateCapacityReservationProfile(
+                        this.CapacityReservationGroupId,
+                        this.IsParameterBound(c => c.CapacityReservationGroupId),
+                        this.IsParameterBound(c => c.DisableCapacityReservationAssignment) ? this.DisableCapacityReservationAssignment.IsPresent : (bool?)null);


+                        CapacityReservationProfile requestedCapacityReservation = CapacityReservationAssignmentHelper.CreateCapacityReservationProfile(
+                            this.CapacityReservationGroupId,
+                            isCapacityReservationGroupIdBound,
+                            isDisableCapacityReservationAssignmentBound ? this.DisableCapacityReservationAssignment.IsPresent : (bool?)null);


…ections

Copilot

🔵 Needs a closer look

Unresolved validation and serialization issues, missing end-to-end removal coverage, and an incorrect issue reference remain.

2 open findings

Add Update-AzVM coverage for capacity reservation changes
Test VMSS PATCH and PUT removal of capacity reservation groups

🧠 Review effort: Lite

Give feedback about Copilot approvals in this survey to enter a drawing for a $150 gift card.

…ections

Copilot

🔵 Needs a closer look

Moderate config-builder and changelog issues remain, and key null/false update paths lack end-to-end coverage.

2 open issues

_{Review effort: Lite}

Initial plan

d6e7a93

Copilot AI assigned Copilot and Haider Agha (haagha) Sep 22, 2026

Copilot AI lite review requested due to automatic review settings September 22, 2026 15:35

Copilot AI reviewed Sep 22, 2026

View reviewed changes

Copilot started work on behalf of Haider Agha (haagha) September 22, 2026 15:39

View session

Fix capacity reservation assignment handling

320ef16

Co-authored-by: haagha <64601174+haagha@users.noreply.github.com>

Copilot AI review requested due to automatic review settings September 22, 2026 15:49

Copilot AI reviewed Sep 22, 2026

View reviewed changes

Copilot AI and others added 2 commits September 22, 2026 15:50

Address validation review feedback

def6bf1

Co-authored-by: haagha <64601174+haagha@users.noreply.github.com>

Refine capacity reservation serialization helper

988d838

Co-authored-by: haagha <64601174+haagha@users.noreply.github.com>

Copilot AI review requested due to automatic review settings September 22, 2026 15:52

Address remaining validation feedback

31a3844

Co-authored-by: haagha <64601174+haagha@users.noreply.github.com>

Copilot started reviewing on behalf of Haider Agha (haagha) September 22, 2026 15:55

View session

Copilot AI and others added 2 commits September 22, 2026 15:56

Tighten validation feedback updates

4babccc

Co-authored-by: haagha <64601174+haagha@users.noreply.github.com>

Polish capacity reservation handling

69af92b

Co-authored-by: haagha <64601174+haagha@users.noreply.github.com>

Copilot AI changed the title ~~[WIP] Fix capacity reservation assignment corrections for Az.Compute~~ Fix Compute capacity reservation assignment semantics Sep 22, 2026

Copilot finished work on behalf of Haider Agha (haagha) September 22, 2026 15:59

Copilot AI requested a review from Haider Agha (haagha) September 22, 2026 15:59

Copilot AI reviewed Sep 22, 2026

View reviewed changes

Comment thread src/Compute/Compute/ChangeLog.md Outdated

Copilot AI review requested due to automatic review settings September 22, 2026 16:04

Copilot started reviewing on behalf of Haider Agha (haagha) September 22, 2026 16:10

View session

Copilot AI reviewed Sep 22, 2026

View reviewed changes

Haider Agha (haagha) marked this pull request as ready for review September 22, 2026 17:31

Merge branch 'main' into copilot/az-compute-capacity-reservation-corr…

91e9541

…ections

Copilot AI lite review requested due to automatic review settings October 8, 2026 00:10

NoriZC previously approved these changes Oct 8, 2026

View reviewed changes

Copilot started reviewing on behalf of Haider Agha (haagha) October 8, 2026 00:10

View session

NoriZC enabled auto-merge (squash) October 8, 2026 00:10

Copilot AI reviewed Oct 8, 2026

View reviewed changes

Teresa Ritorto (teresaritorto) previously approved these changes Oct 8, 2026

View reviewed changes

Merge branch 'main' into copilot/az-compute-capacity-reservation-corr…

7dde431

…ections

NoriZC dismissed stale reviews from Teresa Ritorto (teresaritorto) and themself via 7dde431 October 19, 2026 11:30

Copilot AI lite review requested due to automatic review settings October 19, 2026 11:30

Copilot started reviewing on behalf of Haider Agha (haagha) October 19, 2026 11:30

View session

JaysonTaiMicrosoft approved these changes Oct 19, 2026

View reviewed changes

NoriZC added the Waiting for CI label Oct 19, 2026

Copilot AI reviewed Oct 19, 2026

View reviewed changes

Navigation Menu

Repository navigation

Fix Compute capacity reservation assignment semantics - #30182

Fix Compute capacity reservation assignment semantics#30182
Haider Agha (haagha) with Copilot wants to merge 9 commits into
mainfrom
copilot/az-compute-capacity-reservation-corrections

Copilot AI commented Sep 22, 2026 •

edited by x-engineering-agent Bot

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

azure-pipelines Bot commented Sep 22, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Type	Cmdlet	Example	Line	RuleName	Description	Extent	Remediation
⚠️	New-AzVmssConfig	1	1	Unassigned_Variable	New-AzVmssConfig -Location $Loc is a null-valued parameter value.	-Location	Assign value for $Loc.
⚠️	New-AzVmssConfig	1	1	Unassigned_Variable	New-AzVmssConfig -NetworkInterfaceConfiguration $NetCfg is a null-valued parameter value.	-NetworkInterfaceConfiguration	Assign value for $NetCfg.
⚠️	New-AzVmssConfig	1	2	Unassigned_Variable	Add-AzVmssNetworkInterfaceConfiguration -IPConfiguration $IPCfg is a null-valued parameter value.	-IPConfiguration	Assign value for $IPCfg.
⚠️	New-AzVmssConfig	1	3	Unassigned_Variable	Set-AzVmssOsProfile -AdminUsername $adminUsername is a null-valued parameter value.	-AdminUsername	Assign value for $adminUsername.
⚠️	New-AzVmssConfig	1	3	Unassigned_Variable	Set-AzVmssOsProfile -AdminPassword $AdminPassword is a null-valued parameter value.	-AdminPassword	Assign value for $AdminPassword.
⚠️	New-AzVmssConfig	1	5	Unassigned_Variable	Set-AzVmssStorageProfile -ImageReferenceOffer $ImgRef.Offer is a null-valued parameter value.	-ImageReferenceOffer	Assign value for $ImgRef.Offer.
⚠️	New-AzVmssConfig	1	5	Unassigned_Variable	Set-AzVmssStorageProfile -ImageReferenceSku $ImgRef.Skus is a null-valued parameter value.	-ImageReferenceSku	Assign value for $ImgRef.Skus.
⚠️	New-AzVmssConfig	1	5	Unassigned_Variable	Set-AzVmssStorageProfile -ImageReferenceVersion $ImgRef.Version is a null-valued parameter value.	-ImageReferenceVersion	Assign value for $ImgRef.Version.
⚠️	New-AzVmssConfig	1	6	Unassigned_Variable	Set-AzVmssStorageProfile -ImageReferencePublisher $ImgRef.PublisherName is a null-valued parameter value.	-ImageReferencePublisher	Assign value for $ImgRef.PublisherName.
⚠️	New-AzVmssConfig	1	6	Unassigned_Variable	Set-AzVmssStorageProfile -VhdContainer $VHDContainer is a null-valued parameter value.	-VhdContainer	Assign value for $VHDContainer.
⚠️	New-AzVmssConfig	1	7	Unassigned_Variable	Add-AzVmssAdditionalUnattendContent -ComponentName $AUCComponentName is a null-valued parameter value.	-ComponentName	Assign value for $AUCComponentName.
⚠️	New-AzVmssConfig	1	7	Unassigned_Variable	Add-AzVmssAdditionalUnattendContent -Content $AUCContent is a null-valued parameter value.	-Content	Assign value for $AUCContent.
⚠️	New-AzVmssConfig	1	7	Unassigned_Variable	Add-AzVmssAdditionalUnattendContent -PassName $AUCPassName is a null-valued parameter value.	-PassName	Assign value for $AUCPassName.
⚠️	New-AzVmssConfig	1	7	Unassigned_Variable	Add-AzVmssAdditionalUnattendContent -SettingName $AUCSetting is a null-valued parameter value.	-SettingName	Assign value for $AUCSetting.
⚠️	New-AzVmssConfig	1	9	Unassigned_Variable	New-AzVmss -ResourceGroupName $RGName is a null-valued parameter value.	-ResourceGroupName	Assign value for $RGName.
⚠️	New-AzVmssConfig	1	9	Unassigned_Variable	New-AzVmss -Name $VMSSName is a null-valued parameter value.	-Name	Assign value for $VMSSName.
⚠️	New-AzVmssConfig	4	18	Unassigned_Variable	New-AzStorageAccount -ResourceGroupName $rgname is a null-valued parameter value.	-ResourceGroupName	Assign value for $rgname.
⚠️	New-AzVmssConfig	4	18	Unassigned_Variable	New-AzStorageAccount -Location $loc is a null-valued parameter value.	-Location	Assign value for $loc.
⚠️	New-AzVmssConfig	4	19	Unassigned_Variable	Get-AzStorageAccount -ResourceGroupName $rgname is a null-valued parameter value.	-ResourceGroupName	Assign value for $rgname.
⚠️	New-AzVmssConfig	4	23	Unassigned_Variable	New-AzVirtualNetwork -ResourceGroupName $rgname is a null-valued parameter value.	-ResourceGroupName	Assign value for $rgname.
⚠️	New-AzVmssConfig	4	23	Unassigned_Variable	New-AzVirtualNetwork -Location $loc is a null-valued parameter value.	-Location	Assign value for $loc.
⚠️	New-AzVmssConfig	4	24	Unassigned_Variable	Get-AzVirtualNetwork -ResourceGroupName $rgname is a null-valued parameter value.	-ResourceGroupName	Assign value for $rgname.
⚠️	New-AzVmssConfig	4	30	Unassigned_Variable	New-AzVmssConfig -Location $loc is a null-valued parameter value.	-Location	Assign value for $loc.
⚠️	New-AzVmssConfig	4	32	Unassigned_Variable	Set-AzVmssOsProfile -AdminPassword $password is a null-valued parameter value.	-AdminPassword	Assign value for $password.
⚠️	New-AzVmssConfig	4	37	Unassigned_Variable	New-AzVmss -ResourceGroupName $rgname is a null-valued parameter value.	-ResourceGroupName	Assign value for $rgname.
⚠️	New-AzVmssConfig	4	39	Unassigned_Variable	Get-AzVmss -ResourceGroupName $rgname is a null-valued parameter value.	-ResourceGroupName	Assign value for $rgname.
⚠️	New-AzVmssConfig	5	36	Mismatched_Parameter_Value_Type	Set-AzVmssOsProfile -AdminPassword $adminPassword is not an expected parameter value type.	-AdminPassword	Use correct parameter value type. Expected Type is string. Now the type is securestring.(Command).
⚠️	Update-AzVM	1	1	Unassigned_Variable	Update-AzVM -VM $VirtualMachine is a null-valued parameter value.	-VM	Assign value for $VirtualMachine.
⚠️	Update-AzVM	2	13	Unassigned_Variable	New-AzVM -ResourceGroupName $rgname is a null-valued parameter value.	-ResourceGroupName	Assign value for $rgname.
⚠️	Update-AzVM	2	16	Unassigned_Variable	Update-AzVM -ResourceGroupName $rgname is a null-valued parameter value.	-ResourceGroupName	Assign value for $rgname.
⚠️	Update-AzVmss	1	1	Unassigned_Variable	Update-AzVmss -VirtualMachineScaleSet $LocalVMSS is a null-valued parameter value.	-VirtualMachineScaleSet	Assign value for $LocalVMSS.

Conversation

Copilot AI commented Sep 22, 2026 • edited by x-engineering-agent Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🤖 PR Validation — ⚠️ Review suggested

Verification Checklist

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

azure-pipelines Bot commented Sep 22, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot review overview

🟡 Changes recommended

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot review overview

🟡 Changes recommended

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🔵 Needs a closer look

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🔵 Needs a closer look

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Copilot AI commented Sep 22, 2026 •

edited by x-engineering-agent Bot

Loading