Repository navigation
Wait for in-flight blob session acquisition - #7531
Closed
JinmingHu (Jinming-Hu) wants to merge 4 commits into
Closed
JinmingHu (Jinming-Hu) wants to merge 4 commits into
JinmingHu (Jinming-Hu) wants to merge 4 commits into
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
Azure Pipelines: Successfully started running 1 pipeline(s). 9 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make concurrent Blob requests wait for in-flight session acquisition rather than immediately falling back to bearer authentication.
Design
std::timed_mutex. Callers needing acquisition/refresh wait, check their own cancellation/deadline every 100 ms, and recheck the cache after acquiring the lock. Fresh cached sessions bypass the acquisition mutex.AutoandDisabledremain unchanged.This draft is based on public
mainand adds no public API. Authentication/pipeline behavior requires maintainer review before merging.Validation
Tests were neither added nor run, as requested. A full package build was not run.
git -C C:\wd\azure-sdk-for-cpp-session-required diff --check— passed.vswhere.exewarning, butclcompleted successfully without source diagnostics:Pull Request Checklist
Please leverage this checklist as a reminder to address commonly occurring feedback when submitting a pull request to make sure your PR can be reviewed quickly:
See the detailed list in the contributing guide.