Skip to content

[AutoPR azure-mgmt-redhatopenshifthcp]-generated-from-SDK Generation - Python-6720507 - #48635

Open
azure-sdk-automation[bot] wants to merge 2 commits into
mainfrom
sdkauto/azure-mgmt-redhatopenshifthcp-6720110
Open

[AutoPR azure-mgmt-redhatopenshifthcp]-generated-from-SDK Generation - Python-6720507#48635
azure-sdk-automation[bot] wants to merge 2 commits into
mainfrom
sdkauto/azure-mgmt-redhatopenshifthcp-6720110

Conversation

@azure-sdk-automation

@azure-sdk-automation azure-sdk-automation Bot commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

Configurations: 'specification/redhatopenshift/resource-manager/Microsoft.RedHatOpenShift/hcpopenshiftclusters/tspconfig.yaml', SDK Release Type: beta, and CommitSHA: 'de0093f36a71cd80110b11aa06cdd28ca2e28e1c' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=6720507 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release. Release plan link: https://azsdk-releaseplan-dashboard-hveph5aqhhcfhtgu.westus-01.azurewebsites.net/?releaseplan=36142 Submitted by: b-mbarnes@microsoft.com

…soft.RedHatOpenShift/hcpopenshiftclusters/tspconfig.yaml', SDK Release Type: beta, and CommitSHA: '73596619eb5eee265ffb62bad6afe37216a838c7' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=6720110 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release.
Copilot AI balanced review requested due to automatic review settings August 19, 2026 13:44
@azure-sdk-automation azure-sdk-automation Bot added the auto-release When merged to main, release pipelines for this PR's changed packages trigger automatically. label Aug 19, 2026
@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 1 pipeline(s).
9 pipeline(s) were filtered out due to trigger conditions.
There may be pipelines that require an authorized user to comment /azp run to run.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot could not run the full agentic suite for this review because it was automatically requested on a bot-authored pull request. Request a review from Copilot under Reviewers to retry with the full agentic suite. Improved support for bot-authored pull requests is coming soon.

This PR introduces a new azure-mgmt-redhatopenshifthcp Python management SDK package (generated from azure-rest-api-specs) along with CI pipeline integration, generated samples, and generated (currently skipped) tests.

Changes:

  • Add Azure Pipelines CI configuration for the new redhatopenshifthcp service directory.
  • Add the generated Python management client (sync/async clients, models/enums, typed dicts, packaging metadata).
  • Add generated samples and recorded-test scaffolding (tests currently marked skipped).

Reviewed changes

Copilot reviewed 72 out of 75 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
sdk/redhatopenshifthcp/ci.yml Adds CI pipeline trigger + templated stages for the new SDK package.
sdk/redhatopenshifthcp/azure-mgmt-redhatopenshifthcp/tsp-location.yaml Records the swagger/spec location and source commit for codegen.
sdk/redhatopenshifthcp/azure-mgmt-redhatopenshifthcp/pyproject.toml Defines packaging/build metadata for the new Python package.
sdk/redhatopenshifthcp/azure-mgmt-redhatopenshifthcp/dev_requirements.txt Adds developer dependencies for building/testing the package.
sdk/redhatopenshifthcp/azure-mgmt-redhatopenshifthcp/apiview-properties.json Maps Python types/operations to cross-language APIView identifiers.
sdk/redhatopenshifthcp/azure-mgmt-redhatopenshifthcp/api.metadata.yml Captures codegen metadata (parser/python versions, hash).
sdk/redhatopenshifthcp/azure-mgmt-redhatopenshifthcp/_metadata.json Captures codegen metadata (api version, emitter version, spec commit).
sdk/redhatopenshifthcp/azure-mgmt-redhatopenshifthcp/README.md Adds package readme with install/authentication guidance.
sdk/redhatopenshifthcp/azure-mgmt-redhatopenshifthcp/CHANGELOG.md Adds initial changelog entry for 1.0.0b1.
sdk/redhatopenshifthcp/azure-mgmt-redhatopenshifthcp/LICENSE Adds MIT license text for the package.
sdk/redhatopenshifthcp/azure-mgmt-redhatopenshifthcp/MANIFEST.in Controls which files are included in the source distribution.
sdk/redhatopenshifthcp/azure-mgmt-redhatopenshifthcp/azure/init.py Declares azure as a namespace package portion.
sdk/redhatopenshifthcp/azure-mgmt-redhatopenshifthcp/azure/mgmt/init.py Declares azure.mgmt as a namespace package portion.
sdk/redhatopenshifthcp/azure-mgmt-redhatopenshifthcp/azure/mgmt/redhatopenshifthcp/init.py Exposes the sync client, version, and patch hook.
sdk/redhatopenshifthcp/azure-mgmt-redhatopenshifthcp/azure/mgmt/redhatopenshifthcp/_version.py Defines the package version.
sdk/redhatopenshifthcp/azure-mgmt-redhatopenshifthcp/azure/mgmt/redhatopenshifthcp/_patch.py Adds the customization “patch” entrypoint.
sdk/redhatopenshifthcp/azure-mgmt-redhatopenshifthcp/azure/mgmt/redhatopenshifthcp/_configuration.py Adds sync client configuration and policy wiring.
sdk/redhatopenshifthcp/azure-mgmt-redhatopenshifthcp/azure/mgmt/redhatopenshifthcp/_client.py Adds the generated sync management client implementation.
sdk/redhatopenshifthcp/azure-mgmt-redhatopenshifthcp/azure/mgmt/redhatopenshifthcp/_utils/init.py Adds generated utils package marker.
sdk/redhatopenshifthcp/azure-mgmt-redhatopenshifthcp/azure/mgmt/redhatopenshifthcp/types.py Adds public TypedDict shapes for request/response payloads.
sdk/redhatopenshifthcp/azure-mgmt-redhatopenshifthcp/azure/mgmt/redhatopenshifthcp/py.typed Marks the package as typed (PEP 561).
sdk/redhatopenshifthcp/azure-mgmt-redhatopenshifthcp/azure/mgmt/redhatopenshifthcp/models/_patch.py Adds model-layer patch hook for customizations.
sdk/redhatopenshifthcp/azure-mgmt-redhatopenshifthcp/azure/mgmt/redhatopenshifthcp/models/_enums.py Adds generated enums used by the models/types.
sdk/redhatopenshifthcp/azure-mgmt-redhatopenshifthcp/azure/mgmt/redhatopenshifthcp/models/init.py Re-exports models/enums plus patch hook.
sdk/redhatopenshifthcp/azure-mgmt-redhatopenshifthcp/azure/mgmt/redhatopenshifthcp/operations/_patch.py Adds operations-layer patch hook.
sdk/redhatopenshifthcp/azure-mgmt-redhatopenshifthcp/azure/mgmt/redhatopenshifthcp/operations/init.py Re-exports operation groups plus patch hook.
sdk/redhatopenshifthcp/azure-mgmt-redhatopenshifthcp/azure/mgmt/redhatopenshifthcp/aio/init.py Exposes the async client and patch hook.
sdk/redhatopenshifthcp/azure-mgmt-redhatopenshifthcp/azure/mgmt/redhatopenshifthcp/aio/_patch.py Adds async-layer patch entrypoint.
sdk/redhatopenshifthcp/azure-mgmt-redhatopenshifthcp/azure/mgmt/redhatopenshifthcp/aio/_configuration.py Adds async client configuration and policy wiring.
sdk/redhatopenshifthcp/azure-mgmt-redhatopenshifthcp/azure/mgmt/redhatopenshifthcp/aio/_client.py Adds the generated async management client implementation.
sdk/redhatopenshifthcp/azure-mgmt-redhatopenshifthcp/azure/mgmt/redhatopenshifthcp/aio/operations/_patch.py Adds async operations-layer patch hook.
sdk/redhatopenshifthcp/azure-mgmt-redhatopenshifthcp/azure/mgmt/redhatopenshifthcp/aio/operations/init.py Re-exports async operation groups plus patch hook.
sdk/redhatopenshifthcp/azure-mgmt-redhatopenshifthcp/generated_tests/conftest.py Adds test-proxy sanitizers for recorded tests.
sdk/redhatopenshifthcp/azure-mgmt-redhatopenshifthcp/generated_tests/test_red_hat_open_shift_operations.py Adds generated (skipped) sync operations tests scaffold.
sdk/redhatopenshifthcp/azure-mgmt-redhatopenshifthcp/generated_tests/test_red_hat_open_shift_operations_async.py Adds generated (skipped) async operations tests scaffold.
sdk/redhatopenshifthcp/azure-mgmt-redhatopenshifthcp/generated_tests/test_red_hat_open_shift_node_pools_operations.py Adds generated (skipped) sync node-pools tests scaffold.
sdk/redhatopenshifthcp/azure-mgmt-redhatopenshifthcp/generated_tests/test_red_hat_open_shift_node_pools_operations_async.py Adds generated (skipped) async node-pools tests scaffold.
sdk/redhatopenshifthcp/azure-mgmt-redhatopenshifthcp/generated_tests/test_red_hat_open_shift_external_auths_operations.py Adds generated (skipped) sync external-auths tests scaffold.
sdk/redhatopenshifthcp/azure-mgmt-redhatopenshifthcp/generated_tests/test_red_hat_open_shift_external_auths_operations_async.py Adds generated (skipped) async external-auths tests scaffold.
sdk/redhatopenshifthcp/azure-mgmt-redhatopenshifthcp/generated_tests/test_red_hat_open_shift_hcp_open_shift_versions_operations.py Adds generated (skipped) sync versions tests scaffold.
sdk/redhatopenshifthcp/azure-mgmt-redhatopenshifthcp/generated_tests/test_red_hat_open_shift_hcp_open_shift_versions_operations_async.py Adds generated (skipped) async versions tests scaffold.
sdk/redhatopenshifthcp/azure-mgmt-redhatopenshifthcp/generated_tests/test_red_hat_open_shift_hcp_operator_identity_role_sets_operations.py Adds generated (skipped) sync role-sets tests scaffold.
sdk/redhatopenshifthcp/azure-mgmt-redhatopenshifthcp/generated_tests/test_red_hat_open_shift_hcp_operator_identity_role_sets_operations_async.py Adds generated (skipped) async role-sets tests scaffold.
sdk/redhatopenshifthcp/azure-mgmt-redhatopenshifthcp/generated_tests/test_red_hat_open_shift_hcp_open_shift_clusters_operations.py Adds generated (skipped) sync clusters tests scaffold.
sdk/redhatopenshifthcp/azure-mgmt-redhatopenshifthcp/generated_tests/test_red_hat_open_shift_hcp_open_shift_clusters_operations_async.py Adds generated (skipped) async clusters tests scaffold.
sdk/redhatopenshifthcp/azure-mgmt-redhatopenshifthcp/generated_samples/operations_list_minimum_set_gen.py Adds generated sample for listing operations (minimum set).
sdk/redhatopenshifthcp/azure-mgmt-redhatopenshifthcp/generated_samples/operations_list_maximum_set_gen.py Adds generated sample for listing operations (maximum set).
sdk/redhatopenshifthcp/azure-mgmt-redhatopenshifthcp/generated_samples/node_pools_get_maximum_set_gen.py Adds generated sample for getting a node pool (maximum set).
sdk/redhatopenshifthcp/azure-mgmt-redhatopenshifthcp/generated_samples/node_pools_list_by_parent_maximum_set_gen.py Adds generated sample for listing node pools (maximum set).
sdk/redhatopenshifthcp/azure-mgmt-redhatopenshifthcp/generated_samples/node_pools_create_or_update_maximum_set_gen.py Adds generated sample for creating/updating node pools (maximum set).
sdk/redhatopenshifthcp/azure-mgmt-redhatopenshifthcp/generated_samples/node_pools_update_maximum_set_gen.py Adds generated sample for updating node pools (maximum set).
sdk/redhatopenshifthcp/azure-mgmt-redhatopenshifthcp/generated_samples/node_pools_delete_maximum_set_gen.py Adds generated sample for deleting node pools (maximum set).
sdk/redhatopenshifthcp/azure-mgmt-redhatopenshifthcp/generated_samples/hcp_open_shift_versions_get_maximum_set_gen.py Adds generated sample for getting versions (maximum set).
sdk/redhatopenshifthcp/azure-mgmt-redhatopenshifthcp/generated_samples/hcp_open_shift_versions_list_maximum_set_gen.py Adds generated sample for listing versions (maximum set).
sdk/redhatopenshifthcp/azure-mgmt-redhatopenshifthcp/generated_samples/hcp_operator_identity_role_sets_get_maximum_set_gen.py Adds generated sample for getting operator role sets.
sdk/redhatopenshifthcp/azure-mgmt-redhatopenshifthcp/generated_samples/hcp_operator_identity_role_sets_list_maximum_set_gen.py Adds generated sample for listing operator role sets.
sdk/redhatopenshifthcp/azure-mgmt-redhatopenshifthcp/generated_samples/hcp_open_shift_clusters_get_maximum_set_gen.py Adds generated sample for getting clusters (maximum set).
sdk/redhatopenshifthcp/azure-mgmt-redhatopenshifthcp/generated_samples/hcp_open_shift_clusters_list_by_resource_group_maximum_set_gen.py Adds generated sample for listing clusters by RG.
sdk/redhatopenshifthcp/azure-mgmt-redhatopenshifthcp/generated_samples/hcp_open_shift_clusters_list_by_subscription_maximum_set_gen.py Adds generated sample for listing clusters by subscription.
sdk/redhatopenshifthcp/azure-mgmt-redhatopenshifthcp/generated_samples/hcp_open_shift_clusters_create_or_update_maximum_set_gen.py Adds generated sample for create/update clusters (maximum set).
sdk/redhatopenshifthcp/azure-mgmt-redhatopenshifthcp/generated_samples/hcp_open_shift_clusters_update_maximum_set_gen.py Adds generated sample for updating clusters (maximum set).
sdk/redhatopenshifthcp/azure-mgmt-redhatopenshifthcp/generated_samples/hcp_open_shift_clusters_delete_maximum_set_gen.py Adds generated sample for deleting clusters (maximum set).
sdk/redhatopenshifthcp/azure-mgmt-redhatopenshifthcp/generated_samples/hcp_open_shift_clusters_request_admin_credential_maximum_set_gen.py Adds generated sample for requesting admin credentials.
sdk/redhatopenshifthcp/azure-mgmt-redhatopenshifthcp/generated_samples/hcp_open_shift_clusters_revoke_credentials_maximum_set_gen.py Adds generated sample for revoking credentials.
sdk/redhatopenshifthcp/azure-mgmt-redhatopenshifthcp/generated_samples/external_auths_get_maximum_set_gen.py Adds generated sample for getting external auth (maximum set).
sdk/redhatopenshifthcp/azure-mgmt-redhatopenshifthcp/generated_samples/external_auths_list_by_parent_maximum_set_gen.py Adds generated sample for listing external auths (maximum set).
sdk/redhatopenshifthcp/azure-mgmt-redhatopenshifthcp/generated_samples/external_auths_create_or_update_maximum_set_gen.py Adds generated sample for create/update external auths (maximum set).
sdk/redhatopenshifthcp/azure-mgmt-redhatopenshifthcp/generated_samples/external_auths_update_maximum_set_gen.py Adds generated sample for updating external auths (maximum set).
sdk/redhatopenshifthcp/azure-mgmt-redhatopenshifthcp/generated_samples/external_auths_delete_maximum_set_gen.py Adds generated sample for deleting external auths (maximum set).
Suppressed comments (6)

sdk/redhatopenshifthcp/azure-mgmt-redhatopenshifthcp/generated_samples/node_pools_update_maximum_set_gen.py:1

  • The autoscaling bounds are invalid (min is greater than max). This sample will fail service-side validation; update the sample values so that min <= max.
    sdk/redhatopenshifthcp/azure-mgmt-redhatopenshifthcp/generated_samples/node_pools_create_or_update_maximum_set_gen.py:1
  • location must be a valid Azure region name (e.g., eastus, uksouth). Using an arbitrary string will fail at runtime; please replace this with a real region or a clearly-marked placeholder like AZURE_LOCATION.
    sdk/redhatopenshifthcp/azure-mgmt-redhatopenshifthcp/generated_tests/conftest.py:1
  • These sanitizers treat environment variable values as regex patterns. Secrets (especially AZURE_CLIENT_SECRET) can contain regex metacharacters, which can break sanitization (invalid regex) or cause overbroad matches. Escape the values (e.g., via re.escape) or use a sanitizer helper intended for literal string matching (if available in devtools_testutils).
    sdk/redhatopenshifthcp/azure-mgmt-redhatopenshifthcp/azure/mgmt/redhatopenshifthcp/types.py:1
  • This docstring example appears truncated/malformed (missing closing quote and the end of the example), which can confuse users reading generated docs. Please fix the example text so it is syntactically complete and readable.
    sdk/redhatopenshifthcp/azure-mgmt-redhatopenshifthcp/tsp-location.yaml:1
  • additionalDirectories is present but has no value, which can be interpreted as null and may break tooling expecting a list. Prefer omitting the key entirely when unused or setting an explicit empty list (e.g., additionalDirectories: []).
    sdk/redhatopenshifthcp/azure-mgmt-redhatopenshifthcp/pyproject.toml:1
  • In PEP 621 metadata, license is typically specified as a table (e.g., license = { file = \"LICENSE\" } or license = { text = \"...\" }). Using a plain string may be rejected by stricter build backends/validators; consider switching to a PEP 621-compliant form.

💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.

Comment on lines +38 to +40
"2026-06-30-preview" and None. Default value is None. If not set, the operation's default API
version will be used. Note that overriding this default value may result in unsupported
behavior.
Comment on lines +38 to +40
"2026-06-30-preview" and None. Default value is None. If not set, the operation's default API
version will be used. Note that overriding this default value may result in unsupported
behavior.
Comment on lines +4 to +5
recursive-include tests *.py
recursive-include samples *.py *.md
…soft.RedHatOpenShift/hcpopenshiftclusters/tspconfig.yaml', SDK Release Type: beta, and CommitSHA: 'de0093f36a71cd80110b11aa06cdd28ca2e28e1c' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=6720507 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release.
Copilot AI review requested due to automatic review settings August 19, 2026 15:29
@azure-sdk-automation azure-sdk-automation Bot changed the title [AutoPR azure-mgmt-redhatopenshifthcp]-generated-from-SDK Generation - Python-6720110 [AutoPR azure-mgmt-redhatopenshifthcp]-generated-from-SDK Generation - Python-6720507 Aug 19, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Note

This error may be related to your runner configuration. You can now configure runners for Copilot code review separately from Copilot cloud agent by creating a copilot-code-review.yml file with your setup steps. Read the docs for details.

@msyyc Yuchao Yan (msyyc) added the mgmt-review-needed PR for Mgmt SDK is ready to review label Aug 20, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Warning

Threat Detection Engine Failure — The analysis engine could not complete. This is a tooling failure, not a security finding.

What happened

The threat detection results could not be parsed.

Review the workflow run logs for details.

Management SDK PR review

Severity Finding Location Evidence Rule Remediation
Blocking API version changed sdk/redhatopenshifthcp/azure-mgmt-redhatopenshifthcp/_metadata.json First revision 42148ab82c75dca5e95bf3923086cb0d0870cba5 used API version 2026-06-30-preview; latest revision 74ebb0899e88ff5afc053c327bad74187e17560d uses API version 2026-09-01-preview API version drift (deterministic check) Restore the original API version (2026-06-30-preview) or explain the change and obtain reviewer approval before merging

Unverified checks

Unverified checks: None.

Review summary

Reviewed package: sdk/redhatopenshifthcp/azure-mgmt-redhatopenshifthcp (new package, PR #48635).

Checks completed:

  • Version consistency: _version.py (1.0.0b1) matches latest CHANGELOG.md entry (1.0.0b1).
  • Preview API version → beta SDK version: metadata apiVersion is 2026-09-01-preview, _version.py correctly uses 1.0.0b1.
  • Changelog date: release date 2026-08-19 is not more than 3 weeks in the future.
  • pyproject.toml stability flags: is_stable = false and classifier Development Status :: 4 - Beta correctly set for preview version.
  • Client signature: RedHatOpenShiftClient.__init__ in _client.py has credential, subscription_id, base_url in the required order.
  • Client name consistency: _client.py class, README.md usage, and pyproject.toml title all use RedHatOpenShiftClient.
  • README code snippets: sample client instantiation matches the actual constructor signature.

This is an advisory review only; it does not approve or endorse merging the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-release When merged to main, release pipelines for this PR's changed packages trigger automatically. mgmt-review-needed PR for Mgmt SDK is ready to review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants