Skip to content

Fix registry model list view filtering - #48675

Draft
lavakumarrepala wants to merge 2 commits into
mainfrom
fix/ml-registry-model-list-view-type
Draft

Fix registry model list view filtering#48675
lavakumarrepala wants to merge 2 commits into
mainfrom
fix/ml-registry-model-list-view-type

Conversation

@lavakumarrepala

Copy link
Copy Markdown
Member

Forward list_view_type when listing named registry model versions and add regression coverage.

Co-authored-by: Copilot 223556219+Copilot@users.noreply.github.com

Description

Please add an informative description that covers that changes made by the pull request and link all relevant issues.

If an SDK is being regenerated based on a new API spec, a link to the pull request containing these API spec changes should be included above.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

Forward list_view_type when listing named registry model versions and add regression coverage.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 35b39d20-4548-4d8f-ae87-92cba6b554d9
@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 1 pipeline(s).
9 pipeline(s) were filtered out due to trigger conditions.
There may be pipelines that require an authorized user to comment /azp run to run.

@github-actions

Copy link
Copy Markdown
Contributor
[Pilot] PR Pipeline Failure Analysis

What failed

Pipeline: python - pullrequest (Build Analyze) — Build ID 6728622

  • Check: black (code formatting)
  • Package: sdk/ml/azure-ai-ml
  • File: tests/model/unittests/test_model_operations.py

Black detected that the new test method test_list_registry_versions_forwards_list_view_type added by this PR has its signature on a single long line, but Black requires it to be wrapped across multiple lines.

Relevant pipeline output
-    def test_list_registry_versions_forwards_list_view_type(
-        self, mock_model_operation_reg: ModelOperations
-    ) -> None:
+    def test_list_registry_versions_forwards_list_view_type(self, mock_model_operation_reg: ModelOperations) -> None:

would reformat /mnt/vss/_work/1/s/sdk/ml/azure-ai-ml/tests/model/unittests/test_model_operations.py

Oh no! 💥 💔 💥
1 file would be reformatted, 1469 files would be left unchanged.

black check completed with exit code 1

Recommended next steps

  • Run black sdk/ml/azure-ai-ml/tests/model/unittests/test_model_operations.py from the repo root to auto-fix the formatting
  • Commit the reformatted file and push to update the PR
  • See https://aka.ms/ci-fix

Automated fix: Requested

Generated by Pipeline Analysis Next Steps · 32.3 AIC · ⌖ 8.74 AIC · ⊞ 6K ·

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant