-
Notifications
You must be signed in to change notification settings - Fork 348
Add NuGet package metadata and assets for Microsoft.DataApiBuilder.Mcp #3665
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
anushakolan
wants to merge
2
commits into
main
Choose a base branch
from
dev/anushakolan/mcp-nuget-package-creation-clean
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+61
−0
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,35 @@ | ||
| # Data API builder MCP Library | ||
|
|
||
| [](https://opensource.org/licenses/MIT) | ||
|
|
||
| ## About | ||
|
|
||
| **Microsoft.DataApiBuilder.Mcp** provides Model Context Protocol (MCP) integration for [Data API builder](https://learn.microsoft.com/azure/data-api-builder/) (DAB). | ||
|
|
||
| This package is intended for teams that want to host DAB MCP tools in their own .NET applications. | ||
|
|
||
| ## Key capabilities | ||
|
|
||
| - Registers DAB MCP services in dependency injection | ||
| - Maps DAB MCP endpoints for HTTP hosting | ||
| - Uses Data API builder Core capabilities for entity and tool execution | ||
|
|
||
| ## Installation | ||
|
|
||
| ```bash | ||
| dotnet add package Microsoft.DataApiBuilder.Mcp | ||
| ``` | ||
|
|
||
| ## Usage | ||
|
|
||
| This package is designed for ASP.NET Core applications that expose MCP endpoints. | ||
|
|
||
| Use it to register DAB MCP services in dependency injection and map DAB MCP endpoints in your app's hosting pipeline. | ||
|
|
||
| Current distribution scope is internal Azure Artifacts feeds. | ||
|
|
||
| ## Resources | ||
|
|
||
| - [Official Documentation](https://learn.microsoft.com/azure/data-api-builder/) | ||
| - [GitHub Repository](https://github.com/Azure/data-api-builder) | ||
| - [Samples](https://aka.ms/dab/samples) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NOTICE.txt path seems wrong.
The csproj includes:
<None Include="..\..\nuget_mcp\NOTICE.txt" Pack="true" PackagePath="\" Condition="Exists('..\..\nuget_mcp\NOTICE.txt')" />But the README lives at nuget/nuget_mcp/README.md, so the NOTICE path should be ....\nuget\nuget_mcp\NOTICE.txt (note the nuget prefix). Compare with the Core csproj at Azure.DataApiBuilder.Core.csproj:74 which uses ....\nuget_core\NOTICE.txt — that's also missing the nuget prefix, so either both are wrong or there's a top-level nuget_core/ and nuget_mcp/ directory at repo root used by the build pipeline. Worth verifying the intended location — the Condition="Exists(...)" will silently skip it if wrong, meaning the package ships without a NOTICE even when one exists.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the callout. I checked the generated package layout, and the
NOTICE.txtlocation is intentional. The package usesnuget_mcp/NOTICE.txtas the generated NOTICE output, while the README is sourced fromnuget\nuget_mcp\README.md. So theExists(...)path in the MCP csproj matches the current build output convention rather than the README location.That said, I also noticed the current implementation follows the same pattern used by the Core package, so I believe this is consistent with the existing packaging setup. If needed, I can add a short note in the PR to make that distinction clearer.
