Skip to content

fix: address a name collision risk in the MCS handling logic - #397

Open
michaelawyu wants to merge 1 commit into
Azure:mainfrom
michaelawyu:fix/name-collision
Open

fix: address a name collision risk in the MCS handling logic#397
michaelawyu wants to merge 1 commit into
Azure:mainfrom
michaelawyu:fix/name-collision

Conversation

@michaelawyu

Copy link
Copy Markdown
Collaborator

What type of PR is this?

/bug

What this PR does / why we need it:

This PR fixes a name collision situation that might lead to two MCS constantly overwriting the same derived service.

Which issue(s) this PR fixes:

N/A

Requirements:

How has this code been tested

  • UTs
  • ITs

Special notes for your reviewer

N/A

Signed-off-by: michaelawyu <chenyu1@microsoft.com>
@codecov

codecov Bot commented Aug 4, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 70.50360% with 41 lines in your changes missing coverage. Please review.
✅ Project coverage is 67.53%. Comparing base (556170b) to head (4898673).

Files with missing lines Patch % Lines
pkg/controllers/multiclusterservice/controller.go 61.11% 29 Missing and 6 partials ⚠️
pkg/controllers/multiclusterservice/uniquename.go 87.75% 4 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #397      +/-   ##
==========================================
+ Coverage   67.11%   67.53%   +0.42%     
==========================================
  Files          33       34       +1     
  Lines        3783     5012    +1229     
==========================================
+ Hits         2539     3385     +846     
- Misses       1070     1444     +374     
- Partials      174      183       +9     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant