fixes needed to build VisualNodeSystemTest on Linux#6
Open
biglari wants to merge 1 commit into
Open
Conversation
use cross platform method to set compile definitions moved BaseArithmeticOperatorNode::PerformOperation specializations out of class, to fix build error moved BaseArithmeticOperatorNode::Execute to cpp file to fix build error "specialization after instantiation" redefinition of RecordID in VisualNodeSystem fixed by renaming variable
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I wanted to run the tests branch and had various build errors using gcc 14.2 on Linux Mint 22.3, 64-bit. This is an attempt to fix those build errors to be able to build the tests branch on Linux. Another pull request will provide the changes to the tests branch.
Since the Tests build with
VISUAL_NODE_SYSTEM_BUILD_EXECUTION_FLOW_NODESenabled, the fixes to get this to build in the tests branch come down to getting the execution flow nodes to build correctly.The following fixes were made:
BaseArithmeticOperatorNode::PerformOperationspecializations out of class, to fix build errorBaseArithmeticOperatorNode::Executeto cpp file to fix build error "specialization after instantiation"RecordIDinVisualNodeSystem::UnlinkNodeAreasfixed by renaming variableI updated the MasterBranchCode submodule in the tests branch to newest (673cdaa) and then applied the fixes included in this pull request. I then applied fixes to the tests branch until I got it to build. I ran the tests which completed with following results:
Since I was not able to run the tests before applying fixes, I am not sure if the failures were caused by my changes to the master branch, the tests branch, or the updating of the submodule to newest.
I am unable to test on MSVC since I do not have a windows system to test on.