Repository navigation
Conversation
Original binary fix: Crash when receiving message from disconnected player [Client] A: 39E7DA O: CC CC CC CC CC N: E9 0F 0B 00 00 A: 39E7F4 O: 23 N: E5
Original fix: # This fixes random crash when entering a vehicle [Client] A: 21F6C0 O: 8B 10 N: EB 41 A: 21F703 O: CC CC CC CC N: 85 C0 74 E4 A: 21F707 O: CC CC CC CC N: 8B 10 EB B9
|
maybe mark these with a |
Didnt we agree that we keep an extra branch for the true 1:1 source? My last PR already fixes for crashes we discovered, not issues with the reconstruction of source |
yeah but the vanilla branch is not 1:1 source either, and no one seems to be maintaining it :P Both retail and non-retail related fixes on the main branch got mixed up already, we'd have to backport each change now selectively, and I don't think that'll happen. With those null checks in place, the bug will not crash the game, but instead will be silently ignored, which imo might even be worse. So at least I'd be good to at least have some sort of comment/tag that the thing is a deliberate change compared to retail. |
|
Added the comment to changes from this PR as well as previous. As for the null checking inside the functions, on the |
Porting more fixes of crashes from PR