Repository navigation
Conversation
Recover the client's demo playback path from the retail BF2.exe and the symbolized dedicated ELF, so a .bf2demo recorded by a 1.50 server plays from the BattleRecorder menu page: - DemoRecorder playback stream: initPlayback (user camera), openPlaybackStream, readData, internalReadData, readNextFrameHeader and handleSpecialPacket, the camera arm of close() and the destructor; stopCameraRecording closes, as both binaries do - DemoSpectatorCamera (new translation unit): free and follow cameras, spectator keys, slow-motion presets, nametag target and playback view; the DemoRecorder forwarders replace their stops - GameClient: load, update, receive, setSimulationRate, playDemo, restartDemo, handleDataBlock and the demo slots; the IGameClient demo slots keep their positions with [INFERRED] names, and isDemoPlaying becomes isDemoAtEnd - BF2Engine::playDemo hides the HUD; HudInformationLayer shows the demo camera and the followed player - BattleRecorder: DemoLibrary derives from HTTPRequest; getListEntries "demos" / "demobm" and Multiplay.playDemo / deleteDemo - bf2_demo_playback_read joins bf2_run_checks; new BattleRecorder fixture
The HUD's demo radio menus run demo.shutdownDemo (end-user defaults) and demo.restartDemo, togglePlayerDemo, toggleCameraDemo and toggleDemoPauseOrPlay (full-access defaults). Kept in its own commit because B2BF#56 registers the same commands against the old IGameClient slot names.
Contributor
|
Gonna test it later but it already looks quite good |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Community -> Battlerecorder -> Select File -> Play File