Skip to content

fix: upgrade basic-ftp to 5.3.1 (CVE-2026-27699) - #154

Closed
anupamme wants to merge 2 commits into
BabylonJS:masterfrom
anupamme:fix-repo-assets-cve-2026-27699-basic-ftp
Closed

anupamme wants to merge 2 commits into
BabylonJS:masterfrom
anupamme:fix-repo-assets-cve-2026-27699-basic-ftp

Conversation

@anupamme

@anupamme anupamme commented Sep 18, 2026

Copy link
Copy Markdown

This upgrades basic-ftp (currently 5.1.0) to 5.3.1, which carries the fix for CVE-2026-27699. The package is present in this repository's dependency tree; I have not verified that your code reaches the affected function.

Reference: CVE-2026-27699

What changed

  • libGenerator/package.json
  • libGenerator/package-lock.json

Verification

No automated check could be run against this repository, so this change is unverified beyond review. Please treat it as a suggestion.

Automated dependency upgrade by OrbisAI Security

@RaananW RaananW left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 This review comment was created by an AI agent.

Thank you for updating this dependency. Two small changes would make this easier to review and maintain:

  • The title and body say 5.2.0, but the lockfile and overrides use 5.3.1. Please update the PR text to match.
  • The override lists six parent packages, but this lockfile shows only get-uri depends on basic-ftp. Please consider one top-level "basic-ftp": "5.3.1" override instead.

I found no blocking code or security issue. The only reported check is GitGuardian, so build and test verification is still unavailable.

The lockfile shows only get-uri depends on basic-ftp; the other five
parent-scoped overrides were unnecessary.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@anupamme anupamme changed the title fix: upgrade basic-ftp to 5.2.0 (CVE-2026-27699) fix: upgrade basic-ftp to 5.3.1 (CVE-2026-27699) Sep 19, 2026
@anupamme

Copy link
Copy Markdown
Author

Review comments addressed. Pls review.

@RaananW

RaananW commented Sep 19, 2026

Copy link
Copy Markdown
Member

Apologies. I prefer doing this kind of work myself. I am closing this PR for now.

@RaananW RaananW closed this Sep 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants