Use a coherent system SDK for Apple builds - #1783
Open
matthargett wants to merge 1 commit into
Open
matthargett wants to merge 1 commit into
matthargett wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to make Apple/macOS builds use a consistent Xcode SDK sysroot (avoiding mixed Command Line Tools + Xcode SDK headers/frameworks) and to treat JavaScriptCore framework headers as system headers when building napi with the JavaScriptCore engine, preventing SDK diagnostics from being promoted to errors under warnings-as-errors builds.
Changes:
- Default top-level macOS builds (when not using an explicit toolchain/sysroot and not targeting iOS/visionOS) to
CMAKE_OSX_SYSROOT=macosx. - Add
-iframeworkpropagation on Apple JavaScriptCore builds so JavaScriptCore framework headers are treated as system headers fornapiand its consumers.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| CMakeLists.txt | Defaults top-level macOS builds to the selected Xcode macosx SDK when no sysroot/toolchain is explicitly provided. |
| Dependencies/CMakeLists.txt | Adds compiler flags to classify JavaScriptCore framework headers as system headers for napi consumers on Apple builds. |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Default top-level macOS builds to the selected Xcode SDK instead of allowing Command Line Tools headers to mix with Xcode frameworks. Mark the JavaScriptCore framework search path as a system framework through napi so JsRuntimeHost's pedantic warnings-as-errors policy ignores SDK implementation diagnostics without suppressing project warnings.\n\nThis fixes Xcode 26.5 nullability, invalid UTF-8, and related framework-header failures while leaving explicit cross-compilation toolchains and Apple mobile platforms unchanged.
matthargett
force-pushed
the
apple-sdk-build-consistency
branch
from
September 17, 2026 04:46
d4ee79f to
124fe09
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
macosxSDK when no toolchain or sysroot was suppliednapiand its consumersWhy
An empty macOS sysroot can mix Command Line Tools headers with frameworks from the selected Xcode installation. Diagnostics from that mixed SDK surface become errors under JsRuntimeHost warnings-as-errors builds.
Using one SDK for headers and frameworks fixes the mismatch. Marking the JavaScriptCore framework directory as a system framework keeps SDK implementation diagnostics out of project warning policy without suppressing warnings in BabylonNative or JsRuntimeHost sources.
Validation
masternapiandAppRuntime-isysrootand-iframework.../JavaScriptCore.frameworkand.../JavaScriptCore.framework/JavaScriptCorediscovery forms under a framework directory containing spacesgit diff --check