Standardize asset input loading - #21
Merged
Merged
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
alexchuber
added a commit
to alexchuber/Node-Assets
that referenced
this pull request
Sep 21, 2026
* refactor: standardize asset input loading Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> * fix: handle redirects and reduce loader memory Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> * perf: defer Node transport loading Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> * docs: remove loader gap guide Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> * docs: trim input location guidance Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> * docs: focus input guidance on sources Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> * docs: remove redundant input link Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Intentional behavior changes
Dependencies now follow Babylon's own behavior: OBJ textures use the OBJ directory, redirects do not rebase sidecar paths, and there is no automatic TGA/BMP/GIF conversion or extensionless-image MIME repair. The CLI remains glTF/GLB-only.
Dedicated top-level data-URI source fixtures were removed without adding runtime rejection. Embedded glTF buffer and image data is unchanged.
Review
Synced with
mainat52bfbb7before eight Terra/high self-review passes. Fixed the confirmed browser-bundle finding. A proposed generic filename rewrite was not adopted.