test: wait for serve shutdown before fixture cleanup - #280
Merged
Merged
Conversation
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
odek | c8b4af8 | Commit Preview URL Branch Preview URL |
Sep 28 2026, 07:49 PM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The main-branch cancellation test sometimes removed its temporary session directory while the serve goroutine was still persisting the interrupted turn. Closing the listener started shutdown but did not wait for it, producing
TempDir RemoveAll: directory not emptyin the failing main run.Use a shared test-server lifecycle helper that closes pooled HTTP connections and the listener, then waits for
serveOnListenerto return before environment and directory cleanup. Apply it to the other unjoined serve fixtures and remove the filesystem quiet-period workaround. Reset the cancellation fixtures' WebSocket rate limiter so repeated runs remain isolated. Production code is unchanged.Validation:
go test -race -short -count=1 -timeout 300s ./cmd/odekgolangci-lint run ./cmd/odek: 0 issues.govulncheck ./...: no vulnerabilities found.