Fix docstring from FINISHED state to FINISH in states_info.py - #182
Merged
Conversation
ohmdelta
approved these changes
Aug 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Renamed state FINISHED to FINISH in docstring of GcodeState in states_info.py
I recreated an Enum myself for a Django model and based my states on the docstring (aka FINISHED) rather than the code (FINISH) - not knowing that there was a tiny difference. It caused my logic to fail because FINISHED was never returned by the printer and tests with FINISHED as state did not return the expected results - because printer apparently returns FINISH. I suggest to fix the docstring.
Printer
Firmware Version
Not sure... I used a BambuLab P1S printer.
Type of change