Repository navigation
Fix/core icon support - #54
Merged
Merged
Conversation
Update the default allowed icon blocks to include `blockparty/icon` and `beapi/icon-block` alongside `core/icon`. This improves backward compatibility for WordPress 6.2–6.8 installations using legacy icon plugins, reducing the need for custom filters. `core/icon` is preferred when available (WP 7.0+). The `blockparty_tabs_allowed_icon_blocks` filter now primarily replaces the default list.
This updates the minimum required WordPress version from 6.2 to 6.4. This allows the block to leverage the `directInsert` feature on InnerBlocks, which improves block editor functionality. All related documentation, CI configurations, and test suites have been updated to reflect this new baseline.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Medium Risk
Bumps the supported WordPress floor and changes default tab icon block resolution, which can affect existing sites on 6.2–6.3 or sites that relied on filter-append-only docs.
Overview
Raises the minimum WordPress version to 6.4 and aligns CI (PHPUnit/E2E matrices), docs, and
readme.txtmetadata (including 2.0.0 stable tag and tested up to 7.1). Dev dependencywp-phpunitmoves to 7.1.1.Tab icon support no longer assumes only
core/icon. PHP and the editor now share a default ordered list—core/icon, thenblockparty/icon, thenbeapi/icon-block—andgetRegisteredIconBlocks()keeps only blocks actually registered in the editor. That preserves icons on 6.4–6.9 via legacy plugins while preferring nativecore/iconon WordPress 7.0+. Theblockparty_tabs_allowed_icon_blocksfilter documentation now shows replacing the full list; append-style customization still works.PHPUnit and Jest tests cover the new defaults, registration filtering, and filter behavior. Playwright/webpack comments are updated for the 6.4+ editor canvas assumption.
Reviewed by Cursor Bugbot for commit 5214c47. Bugbot is set up for automated code reviews on this repo. Configure here.