fix(api-platform): remove leftover bundle registration and annotations - #475
Merged
Merged
Conversation
The previous removal of api-platform/core (composer.json + core classes) missed three files that still referenced the bundle: - config/bundles.php: ApiPlatformBundle registration (crashes kernel on boot) - config/routes/api_platform.yaml: route type api_platform (no-op without bundle) - src/Entity/Member.php: @ApiResource, @ApiProperty, @APIFilter annotations These leftovers cause a PHP fatal on every container start, making the beta deploy fail immediately with exit 255.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The previous
chore: remove api-platform/corecommit removed the package from composer but missed three files that still referenced it:config/bundles.phpstill registeredApiPlatformBundle— this crashes the Symfony kernel on every boot withClass "ApiPlatform\Core\Bridge\Symfony\Bundle\ApiPlatformBundle" not found, making the PHP-FPM container exit 255 immediatelyconfig/routes/api_platform.yamlstill declared anapi_platformroute typesrc/Entity/Member.phpstill had@ApiResource,@ApiProperty, and@ApiFilterannotationsTest plan
docker run ghcr.io/bewelcome/rox:docker-beta php-fpmstarts PHP-FPM and reachesready to handle connections