Repository navigation
fix(#168): use hast property names for mapped component props - #183
Merged
BearToCode merged 1 commit intoOct 1, 2026
Merged
Conversation
BearToCode
approved these changes
Oct 1, 2026
Owner
|
Thanks for your contribution |
|
🎉 This PR is included in version @cartamd/plugin-component-v1.1.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #168
Problem
Attributes of a matched element are passed to the mapped component with their raw DOM attribute names on the client (
data-item-id), but with their hast property names on the server (dataItemId). A component like:receives the value during SSR, but
undefinedafterinitializeComponentsruns on the client — sodata-*attributes are effectively unreachable.Fix
initializeComponentsnow maps placeholder attributes throughproperty-information, so client-side props use the same names as the server (data-item-id→dataItemId,class→className,aria-label→ariaLabel, …).data-componentis still excluded. Also documented the prop naming in the component plugin docs.Verification
The repo has no test suite, so I verified with a scripted repro (jsdom + a compiled Svelte component) running against the built package:
{"data-item-id":"12345"}vs SSR{"dataItemId":"12345"}{"dataItemId":"12345","className":"a b","ariaLabel":"label","href":"/x"}(matches SSR)Checks:
pnpm run lint✅ ·pnpm run check✅ (0 errors/0 warnings) ·pnpm run build✅ (all packages + docs).