Skip to content

fix(#184): escape the overlay's plain-text fallback #185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BearToCode merged 4 commits into from
Oct 5, 2026
Merged

fix(#184): escape the overlay's plain-text fallback #185

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c1e5ee9
fix(#184): escape the overlay's plain-text fallback
itsmunzir Oct 4, 2026
491f37a
chore: use provided sanitizer instead of manually escaping HTML chara…
BearToCode Oct 5, 2026
e62d090
chore: remove allowBuilds section from pnpm-workspace.yaml
BearToCode Oct 5, 2026
6eaa1b9
chore: readd early return if lines array is empty
BearToCode Oct 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion packages/carta-md/src/lib/internal/components/Input.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,11 @@
const html = speculativeHighlightUpdate(currentlyHighlightedValue, value, currentOverlay);
currentlyHighlightedValue = value;

return { html, timestamp };
if (carta.sanitizer) {
return { html: carta.sanitizer(html), timestamp };
} else {
return { html, timestamp };
}
} catch (e) {
console.error(`Error executing speculative update: ${e}.`);
// The overlay still holds the previous text, but the debounced highlight is already
Expand Down
Loading