Skip to content

fix(#184): escape HTML on first speculative update #186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BearToCode merged 1 commit into from
Oct 7, 2026
Merged

fix(#184): escape HTML on first speculative update #186

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion packages/carta-md/src/lib/internal/speculative.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,10 @@ const clonePosition = (position: Position): Position => {
};
};

/** Escape text so it is parsed as text, and not as markup, by the overlay. */
const escapeHtml = (text: string): string =>
text.replaceAll('&', '&amp;').replaceAll('<', '&lt;').replaceAll('>', '&gt;');

/**
* Temporary updates the highlight overlay to reflect the changes between two text strings,
* waiting for the actual update to be applied. This way, the user can immediately see the changes,
Expand All @@ -32,7 +36,7 @@ export function speculativeHighlightUpdate(from: string, to: string, currentHTML
let writingPosition: Position = { line: 0, span: 0, char: 0 };
let readingPosition: Position = { line: 0, span: 0, char: 0 };

if (lines.length === 0) return to;
if (lines.length === 0) return escapeHtml(to);

const advance = () => {
writingPosition = clonePosition(readingPosition);
Expand Down
Loading